-
-
Notifications
You must be signed in to change notification settings - Fork 11.2k
[P/D] Log warnings related to prefill KV expiry #21753
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[P/D] Log warnings related to prefill KV expiry #21753
Conversation
Signed-off-by: Nick Hill <nhill@redhat.com>
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds important warning logs for prefill KV cache expiry and notifications for unrecognized requests, and fixes a small memory leak. I've identified a couple of critical issues that could lead to runtime errors and another memory leak. My review provides suggestions to address these.
NickLucche
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for spotting this @njhill !
I think there's a couple %d gemini wanted you to replace :)
Signed-off-by: Nick Hill <nhill@redhat.com>
Signed-off-by: Nick Hill <nhill@redhat.com>
Signed-off-by: Nick Hill <nhill@redhat.com>
Signed-off-by: Nick Hill <nhill@redhat.com> Signed-off-by: x22x22 <wadeking@qq.com>
Signed-off-by: Nick Hill <nhill@redhat.com>
Signed-off-by: Nick Hill <nhill@redhat.com>
Signed-off-by: Nick Hill <nhill@redhat.com> Signed-off-by: Jinzhen Lin <linjinzhen@hotmail.com>
Signed-off-by: Nick Hill <nhill@redhat.com> Signed-off-by: Paul Pak <paulpak58@gmail.com>
Signed-off-by: Nick Hill <nhill@redhat.com> Signed-off-by: Diego-Castan <diego.castan@ibm.com>
Signed-off-by: Nick Hill <nhill@redhat.com>
Signed-off-by: Nick Hill <nhill@redhat.com>
#20139 added a safety-net for releasing prefill blocks that weren't retrieved or notified by a decode worker within a time window (default two minutes).
This PR adds some warning logs both when such expiries occur and when notifications for unrecognized request ids are received.
Also fixes a small leak for the TP case where we don't also flush
consumer_notification_counts_by_reqfor expired requests.cc @NickLucche