Skip to content

Conversation

@KuntaiDu
Copy link
Collaborator

@KuntaiDu KuntaiDu commented Jul 28, 2025

Reverts #21534

This PR introduces fault tolerance to KV cache connector, which is very important feature to have. That said, I think this PR should be reverted because this PR, though has less core change, still contains some compatibility issue and need more feedbacks from community.

This PR is a consensus decision from #21534 .

@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added the v1 label Jul 28, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request reverts the "Exception Handling when Loading KV Cache from Remote Store" feature due to compatibility issues. The changes correctly remove the RandomDropConnector test utility and all associated logic for fault-tolerant KV cache loading from the scheduler, workers, and various data structures.

My review of the changes confirms that the revert appears to be clean and complete. I did not find any remaining artifacts or new issues introduced by this change. This should effectively address the compatibility concerns mentioned in the pull request description.

…re (#21534)"

This reverts commit 15a72ac.

Signed-off-by: KuntaiDu <kuntai@uchicago.edu>
@KuntaiDu KuntaiDu force-pushed the revert-21534-exception_handling branch from 0a8633c to db93e20 Compare July 28, 2025 17:21
@KuntaiDu KuntaiDu enabled auto-merge (squash) July 28, 2025 17:23
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Jul 28, 2025
Copy link
Member

@njhill njhill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @KuntaiDu.

I agree this is a very high priority feature but we should take into account the overlapping existing work and make sure the right people have had a chance to comment.

@KuntaiDu KuntaiDu merged commit b18b417 into main Jul 28, 2025
83 checks passed
@KuntaiDu KuntaiDu deleted the revert-21534-exception_handling branch July 28, 2025 20:15
liuyumoye pushed a commit to liuyumoye/vllm that referenced this pull request Jul 31, 2025
x22x22 pushed a commit to x22x22/vllm that referenced this pull request Aug 5, 2025
…re" (vllm-project#21778)

Signed-off-by: KuntaiDu <kuntai@uchicago.edu>
Signed-off-by: x22x22 <wadeking@qq.com>
Pradyun92 pushed a commit to Pradyun92/vllm that referenced this pull request Aug 6, 2025
npanpaliya pushed a commit to odh-on-pz/vllm-upstream that referenced this pull request Aug 6, 2025
jinzhen-lin pushed a commit to jinzhen-lin/vllm that referenced this pull request Aug 9, 2025
…re" (vllm-project#21778)

Signed-off-by: KuntaiDu <kuntai@uchicago.edu>
Signed-off-by: Jinzhen Lin <linjinzhen@hotmail.com>
noamgat pushed a commit to noamgat/vllm that referenced this pull request Aug 9, 2025
…re" (vllm-project#21778)

Signed-off-by: KuntaiDu <kuntai@uchicago.edu>
Signed-off-by: Noam Gat <noamgat@gmail.com>
paulpak58 pushed a commit to paulpak58/vllm that referenced this pull request Aug 13, 2025
…re" (vllm-project#21778)

Signed-off-by: KuntaiDu <kuntai@uchicago.edu>
Signed-off-by: Paul Pak <paulpak58@gmail.com>
diegocastanibm pushed a commit to diegocastanibm/vllm that referenced this pull request Aug 15, 2025
…re" (vllm-project#21778)

Signed-off-by: KuntaiDu <kuntai@uchicago.edu>
Signed-off-by: Diego-Castan <diego.castan@ibm.com>
epwalsh pushed a commit to epwalsh/vllm that referenced this pull request Aug 28, 2025
zhewenl pushed a commit to zhewenl/vllm that referenced this pull request Aug 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready ONLY add when PR is ready to merge/full CI is needed v1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants