-
-
Notifications
You must be signed in to change notification settings - Fork 11.3k
[Refactor] Remove Duplicate per_block_cast_to_fp8, Remove Dependencies of DeepGEMM
#21787
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Refactor] Remove Duplicate per_block_cast_to_fp8, Remove Dependencies of DeepGEMM
#21787
Conversation
Signed-off-by: yewentao256 <zhyanwentao@126.com>
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request refactors the code by centralizing the per_block_cast_to_fp8 utility and removing its dependencies on the deep_gemm library, which improves maintainability. The changes are consistent across the codebase. There is one issue in test_deepgemm.py where the block_size was not being passed to the new utility function, which could lead to incorrect test behavior. A suggestion has been provided to fix it.
Signed-off-by: yewentao256 <zhyanwentao@126.com>
…ies of DeepGEMM (vllm-project#21787) Signed-off-by: yewentao256 <zhyanwentao@126.com>
…ies of DeepGEMM (vllm-project#21787) Signed-off-by: yewentao256 <zhyanwentao@126.com> Signed-off-by: Jinzhen Lin <linjinzhen@hotmail.com>
…ies of DeepGEMM (vllm-project#21787) Signed-off-by: yewentao256 <zhyanwentao@126.com> Signed-off-by: Noam Gat <noamgat@gmail.com>
…ies of DeepGEMM (vllm-project#21787) Signed-off-by: yewentao256 <zhyanwentao@126.com> Signed-off-by: Paul Pak <paulpak58@gmail.com>
…ies of DeepGEMM (vllm-project#21787) Signed-off-by: yewentao256 <zhyanwentao@126.com> Signed-off-by: Diego-Castan <diego.castan@ibm.com>
…ies of DeepGEMM (vllm-project#21787) Signed-off-by: yewentao256 <zhyanwentao@126.com>
…ies of DeepGEMM (vllm-project#21787) Signed-off-by: yewentao256 <zhyanwentao@126.com>
Purpose
per_block_cast_to_fp8Test
On B200 with DeepGEMM installed.
Origin:
Now: