[Bugfix]: fix metadata file copy in test_sharded_state_loader

[andyxning]

Essential Elements of an Effective PR Description Checklist

• The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
• The test plan, such as providing test command.
• The test results, such as pasting the results comparison before and after, or e2e results
• (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.

Purpose

currently, weights_patterns is ["*.safetensors"] and if file is model.safetensors, then ext is *.safetensors and file.endswith(ext) will be false. As *.safetensors is a pattern, then we should use fnmatch to check whether a file matches the pattern like how ignore_patterns is implemented in huggingface_cli.

Test Plan

NA

Test Result

NA

(Optional) Documentation Update

NA

[github-actions]

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

[gemini-code-assist]

Code Review

This pull request correctly fixes a bug where filename patterns were being checked with endswith instead of fnmatch. The change also correctly handles subdirectories by copying them. However, the new logic doesn't apply the filter patterns to directories, which could lead to incorrect behavior. I've provided a suggestion to apply patterns to both files and directories to make the implementation more robust and consistent with the behavior of similar utilities in huggingface_hub.

[gemini-code-assist]

The current logic correctly uses fnmatch for files, but it unconditionally copies all directories without checking them against weights_patterns. This could lead to incorrect behavior if a weight pattern is intended to match a directory, which deviates from the behavior of ignore_patterns in huggingface_hub that was referenced in the pull request description.

For example, if weights_patterns contained a pattern like "checkpoints", a directory with that name would be copied instead of being ignored.

To make the logic more robust and align with the intended behavior, I suggest checking items against weights_patterns first, regardless of whether they are files or directories. This ensures that directories matching a weight pattern are correctly skipped.

Suggested change

	if os.path.isdir(os.path.join(input_dir, file)):
	continue
	if not any(file.endswith(ext) for ext in weights_patterns):
	shutil.copy(f"{input_dir}/{file}", output_dir)
	shutil.copytree(
	os.path.join(input_dir, file), os.path.join(output_dir, file)
	)
	elif not any(fnmatch.fnmatch(file, ext) for ext in weights_patterns):
	shutil.copy(os.path.join(input_dir, file), output_dir)
	if any(fnmatch.fnmatch(file, ext) for ext in weights_patterns):
	continue
	src_path = os.path.join(input_dir, file)
	if os.path.isdir(src_path):
	shutil.copytree(src_path, os.path.join(output_dir, file))
	else:
	shutil.copy(src_path, output_dir)

[sarckk]

why do we need to copy directories now?

[andyxning]

To be consistent with

vllm/examples/offline_inference/save_sharded_state.py

Lines 87 to 95 in 4cd7fe6

	# Copy metadata files to output directory
	for file in os.listdir(model_path):
	if os.path.splitext(file)[1] not in (".bin", ".pt", ".safetensors"):
	if os.path.isdir(os.path.join(model_path, file)):
	shutil.copytree(
	os.path.join(model_path, file), os.path.join(args.output, file)
	)
	else:
	shutil.copy(os.path.join(model_path, file), args.output)

[sarckk]

looks good, thanks for fixing this. cc: @DarkLight1337 @WoosukKwon