-
-
Notifications
You must be signed in to change notification settings - Fork 11k
[ci] add b200 test placeholder #21866
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: simon-mo <simon.mo@hey.com>
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a new CI test step for the Blackwell GPU architecture. The intention is good, but the implementation has a couple of areas for improvement. My review focuses on making the new test step clearer, more robust, and more effective at validating the target hardware.
| - vllm/ | ||
| commands: | ||
| - nvidia-smi | ||
| - python3 examples/offline_inference/basic/chat.py |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This test command has two significant issues:
- Lack of Specificity: The test is labeled "Blackwell Test" but runs a generic example without any Blackwell-specific configurations. To be a meaningful test for the new architecture, it should validate features unique to Blackwell, such as FP8 data types. Please consider adding arguments to enable and test such features (e.g.,
--dtype float8_e4m3fn). - Implicit Dependency: The command relies on the default model (
meta-llama/Llama-3.2-1B-Instruct) hardcoded inexamples/offline_inference/basic/chat.py. This makes the CI step fragile. To make the test more robust and self-contained, the model should be specified explicitly as a command-line argument.
- python3 examples/offline_inference/basic/chat.py --model meta-llama/Llama-3.2-1B-Instruct --dtype float8_e4m3fn # Or other Blackwell-specific args
|
|
||
| - label: Blackwell Test | ||
| working_dir: "/vllm-workspace/" | ||
| # optional: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The optional: true setting is commented out, which creates ambiguity about the intended behavior of this test step. If this step should not block the pipeline on failure, this line should be uncommented. If the step is mandatory, this commented-out line should be removed to improve clarity and prevent future confusion.
Signed-off-by: simon-mo <simon.mo@hey.com>
Signed-off-by: simon-mo <simon.mo@hey.com>
Signed-off-by: simon-mo <simon.mo@hey.com>
Signed-off-by: simon-mo <simon.mo@hey.com> Signed-off-by: x22x22 <wadeking@qq.com>
Signed-off-by: simon-mo <simon.mo@hey.com>
Signed-off-by: simon-mo <simon.mo@hey.com> Signed-off-by: Jinzhen Lin <linjinzhen@hotmail.com>
Signed-off-by: simon-mo <simon.mo@hey.com> Signed-off-by: Noam Gat <noamgat@gmail.com>
Signed-off-by: simon-mo <simon.mo@hey.com> Signed-off-by: Paul Pak <paulpak58@gmail.com>
Signed-off-by: simon-mo <simon.mo@hey.com> Signed-off-by: Diego-Castan <diego.castan@ibm.com>
Signed-off-by: simon-mo <simon.mo@hey.com>
Signed-off-by: simon-mo <simon.mo@hey.com>
Add B200 Test Demo
Example Build
https://buildkite.com/vllm/ci/builds/25339/steps/canvas?jid=0198589f-bccc-4b20-b539-3305e07a2849