-
-
Notifications
You must be signed in to change notification settings - Fork 11.1k
[ci] mark blackwell test optional for now #21878
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request marks the Blackwell test as optional in the CI pipeline. This is a reasonable temporary measure while the Blackwell node is under development. My feedback is to add a TODO comment to track the work required to make this test mandatory again, which will prevent potential regressions from going unnoticed in the long term.
| working_dir: "/vllm-workspace/" | ||
| gpu: b200 | ||
| # optional: true | ||
| optional: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To ensure this temporary change isn't forgotten, it would be beneficial to add a TODO comment. This will help track the work needed to make the test mandatory once Blackwell support is stable, preventing potential regressions from being missed.
# TODO: Make this test non-optional once Blackwell support is stable.
optional: true
Signed-off-by: x22x22 <wadeking@qq.com>
Signed-off-by: Jinzhen Lin <linjinzhen@hotmail.com>
Signed-off-by: Noam Gat <noamgat@gmail.com>
Signed-off-by: Paul Pak <paulpak58@gmail.com>
Signed-off-by: Diego-Castan <diego.castan@ibm.com>
blackwell node is still in development