-
-
Notifications
You must be signed in to change notification settings - Fork 11.3k
[Misc] Remove pass_config from CompilationConfig dump_json excluded #21911
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Misc] Remove pass_config from CompilationConfig dump_json excluded #21911
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request correctly removes pass_config from the exclusion list in CompilationConfig.__repr__, which will now include it in the logged non-default arguments. This is a useful change for debugging and verifying compilation configurations. The minor docstring typo fix is also a good cleanup. The changes are correct and well-motivated.
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
|
cc @ProExpertProg do we want to include |
|
To add some context: the pass_config has large impact on performance numbers. Currently, we do not know if a non-default pass config is taking effects or not by looking at the logs. If you have other ways to check that please let us know. thanks! |
|
I think originally @youkaichao removed pass config from repr because it's very verbose. But I agree with new passes that heavily affect the FX graph and performance, we should likely include it |
|
Perhaps we could either only display the true values or the non-defaults. Not sure what's best here |
|
@elvischenv Is it possible to only show the "non-default" fields in pass_config? |
Signed-off-by: elvischenv <219235043+elvischenv@users.noreply.github.com>
3abae86 to
adf765d
Compare
|
Update to only show the non-default flags for pass_config: before: PR: |
|
@ProExpertProg FYI, @elvischenv has updated it to only print non-defaults. Does it look okay to you? thanks! |
…llm-project#21911) Signed-off-by: elvischenv <219235043+elvischenv@users.noreply.github.com>
…llm-project#21911) Signed-off-by: elvischenv <219235043+elvischenv@users.noreply.github.com>
…llm-project#21911) Signed-off-by: elvischenv <219235043+elvischenv@users.noreply.github.com> Signed-off-by: Jinzhen Lin <linjinzhen@hotmail.com>
…llm-project#21911) Signed-off-by: elvischenv <219235043+elvischenv@users.noreply.github.com> Signed-off-by: Noam Gat <noamgat@gmail.com>
…llm-project#21911) Signed-off-by: elvischenv <219235043+elvischenv@users.noreply.github.com> Signed-off-by: Paul Pak <paulpak58@gmail.com>
…llm-project#21911) Signed-off-by: elvischenv <219235043+elvischenv@users.noreply.github.com> Signed-off-by: Diego-Castan <diego.castan@ibm.com>
…llm-project#21911) Signed-off-by: elvischenv <219235043+elvischenv@users.noreply.github.com>
…llm-project#21911) Signed-off-by: elvischenv <219235043+elvischenv@users.noreply.github.com> Signed-off-by: Xiao Yu <xiao.yu@amd.com>
…llm-project#21911) Signed-off-by: elvischenv <219235043+elvischenv@users.noreply.github.com>
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.Purpose
The motivation is we cannot find the
compilation_config.pass_configoption fromnon-default args, that's confusing whether our config is working or not.before
after
Test Plan
Test Result
(Optional) Documentation Update