Skip to content

[Misc] Use config definitions from Transformers library #21913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Aug 9, 2025
Merged

[Misc] Use config definitions from Transformers library #21913

merged 6 commits into from
Aug 9, 2025

Conversation

@DarkLight1337
Copy link
Member

@DarkLight1337 DarkLight1337 commented Jul 30, 2025 •
edited by github-actions bot
Loading

Essential Elements of an Effective PR Description Checklist

  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.

Purpose

Follow-up from #21891 (review)

Test Plan

Test Result

(Optional) Documentation Update

@DarkLight1337
[Misc] Use config definitions from Transformers library
2dfa214 
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
@DarkLight1337 DarkLight1337 requested a review from hmellor July 30, 2025 07:45
@DarkLight1337 DarkLight1337 added the ready ONLY add when PR is ready to merge/full CI is needed label Jul 30, 2025
@mergify mergify bot added deepseek Related to DeepSeek models qwen Related to Qwen models labels Jul 30, 2025
gemini-code-assist[bot]
gemini-code-assist bot reviewed Jul 30, 2025
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors several model implementations to use specific configuration classes from the Transformers library instead of the generic PretrainedConfig. This is a positive change that enhances type safety and code clarity. The changes are applied consistently across all relevant files, and the single exception where PretrainedConfig is retained is clearly explained with a comment. The code is clean and I have no further suggestions.

@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

mgoin
mgoin reviewed Jul 30, 2025
View reviewed changes
@hmellor hmellor mentioned this pull request Jul 30, 2025
Merged
@DarkLight1337
Copy link
Member Author

Holding this PR until #21931 and #21934 are both merged

@DarkLight1337
Merge branch 'main' into hf-config
456f92c
@DarkLight1337
Use V2 config
235bffb 
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
@DarkLight1337
Check both
c7df154 
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
@DarkLight1337
Update
a7700d2 
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
@DarkLight1337 DarkLight1337 enabled auto-merge (squash) August 7, 2025 06:22
@hmellor
Copy link
Member

hmellor commented Aug 7, 2025

We should also update the Cohere hint to Union[CohereConfig, Cohere2Config] as it's used for both

@DarkLight1337
Update
302ae63 
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
@vllm-bot vllm-bot merged commit 65552b4 into vllm-project:main Aug 9, 2025
36 of 43 checks passed
@DarkLight1337 DarkLight1337 deleted the hf-config branch August 9, 2025 06:10
paulpak58 pushed a commit to paulpak58/vllm that referenced this pull request Aug 13, 2025
@DarkLight1337 @paulpak58
[Misc] Use config definitions from Transformers library (vllm-project…
e6bee6a 
…#21913)

Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Signed-off-by: Paul Pak <paulpak58@gmail.com>
diegocastanibm pushed a commit to diegocastanibm/vllm that referenced this pull request Aug 15, 2025
@DarkLight1337 @diegocastanibm
[Misc] Use config definitions from Transformers library (vllm-project…
02e7b0f 
…#21913)

Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Signed-off-by: Diego-Castan <diego.castan@ibm.com>
yiliu30 pushed a commit to yiliu30/vllm-fork that referenced this pull request Aug 19, 2025
@DarkLight1337 @yiliu30
[Misc] Use config definitions from Transformers library (vllm-project…
5f825ff 
…#21913)

Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
epwalsh pushed a commit to epwalsh/vllm that referenced this pull request Aug 28, 2025
@DarkLight1337 @epwalsh
[Misc] Use config definitions from Transformers library (vllm-project…
369cb1d 
…#21913)

Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
xiao-llm pushed a commit to xiao-llm/vllm that referenced this pull request Aug 28, 2025
@DarkLight1337 @amd-xiaoyu12
[Misc] Use config definitions from Transformers library (vllm-project…
3c8979f 
…#21913)

Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Signed-off-by: Xiao Yu <xiao.yu@amd.com>
zhewenl pushed a commit to zhewenl/vllm that referenced this pull request Aug 28, 2025
@DarkLight1337 @zhewenl
[Misc] Use config definitions from Transformers library (vllm-project…
3125550 
…#21913)

Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mgoin mgoin mgoin left review comments

@hmellor hmellor hmellor approved these changes

@sighingnow sighingnow Awaiting requested review from sighingnow sighingnow is a code owner

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

deepseek Related to DeepSeek models qwen Related to Qwen models ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@DarkLight1337 @hmellor @mgoin @vllm-bot