-
-
Notifications
You must be signed in to change notification settings - Fork 11.1k
[Core] Enable HF processing on GPU #22070
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
[Core] Enable HF processing on GPU #22070
Conversation
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request enables Hugging Face processor execution on the GPU, a valuable performance enhancement. The changes include comprehensive documentation updates, new tests to validate the functionality, and significant refactoring to support the new feature.
The core logic for GPU processing, including moving data to and from the device and handling configuration, appears correct. The refactoring in the worker and test files improves code clarity and maintainability.
I've identified a couple of high-severity issues related to inefficient dummy data generation during profiling runs in both the GPU and TPU model runners. These inefficiencies could impact the accuracy of memory profiling and should be addressed. My review includes specific suggestions to resolve these issues.
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
|
Documentation preview: https://vllm--22070.org.readthedocs.build/en/22070/ |
|
This pull request has merge conflicts that must be resolved before it can be |
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.Purpose
This PR completes the basic features of #21995 with documentation and tests for it.
Test Plan
Added entrypoints tests to test the functionality.
Test Result
(Optional) Documentation Update