-
-
Notifications
You must be signed in to change notification settings - Fork 11.1k
Revert "[compile][startup] Disable C++ compilation of symbolic shapes" #22122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request reverts a previous change that disabled C++ compilation of symbolic shapes. The original change, intended to improve compile time, unfortunately introduced a critical bug causing compilation failures for models with dynamic shapes. This revert correctly removes the problematic code, restoring the previous stable behavior. The change is clean and necessary. I see no issues with this revert.
…vllm-project#20836)" This reverts commit 9659bc7. Signed-off-by: Xiao Liu <xiszishu@gmail.com>
3578eef to
ebc95cf
Compare
vllm-project#22122) Signed-off-by: Xiao Liu <xiszishu@gmail.com>
vllm-project#22122) Signed-off-by: Xiao Liu <xiszishu@gmail.com> Signed-off-by: Jinzhen Lin <linjinzhen@hotmail.com>
vllm-project#22122) Signed-off-by: Xiao Liu <xiszishu@gmail.com> Signed-off-by: Noam Gat <noamgat@gmail.com>
vllm-project#22122) Signed-off-by: Xiao Liu <xiszishu@gmail.com> Signed-off-by: Paul Pak <paulpak58@gmail.com>
vllm-project#22122) Signed-off-by: Xiao Liu <xiszishu@gmail.com> Signed-off-by: Diego-Castan <diego.castan@ibm.com>
vllm-project#22122) Signed-off-by: Xiao Liu <xiszishu@gmail.com>
vllm-project#22122) Signed-off-by: Xiao Liu <xiszishu@gmail.com>
Reverts #20836
due to the issue in #20836 (comment)
and #20836 (comment)