-
-
Notifications
You must be signed in to change notification settings - Fork 11.2k
[Misc] Bump ray to 2.48.0 #22123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Misc] Bump ray to 2.48.0 #22123
Conversation
Signed-off-by: Rui Qiao <ruisearch42@gmail.com>
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request bumps the ray dependency to version 2.48.0 to resolve a ModuleNotFoundError. The change is straightforward and affects the requirements files. My main concern is the lack of a test plan and results in the pull request description. Given that ray is a core dependency, it's crucial to verify that this version bump does not introduce any regressions. I've left a comment requesting the author to provide testing evidence.
|
|
||
| # Dependencies for NVIDIA GPUs | ||
| ray[cgraph]>=2.43.0, !=2.44.* # Ray Compiled Graph, required for pipeline parallelism in V1. | ||
| ray[cgraph]>=2.48.0 # Ray Compiled Graph, required for pipeline parallelism in V1. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bumping the ray version to 2.48.0 is well-justified to resolve the ModuleNotFoundError.
However, ray is a critical dependency for distributed execution, and version bumps can introduce subtle regressions or performance changes. The pull request description is missing a Test Plan and Test Results, which are essential for a change like this.
To ensure the stability and performance of the project, please:
- Run the full test suite, paying close attention to distributed tests that use the
raybackend. - Update the pull request description with the test plan and a summary of the results, confirming that all tests pass and there are no performance regressions.
Without this validation, we risk merging a change that could break key functionalities.
Signed-off-by: Rui Qiao <ruisearch42@gmail.com>
Signed-off-by: Rui Qiao <ruisearch42@gmail.com> Signed-off-by: Jinzhen Lin <linjinzhen@hotmail.com>
Signed-off-by: Rui Qiao <ruisearch42@gmail.com> Signed-off-by: Noam Gat <noamgat@gmail.com>
Signed-off-by: Rui Qiao <ruisearch42@gmail.com> Signed-off-by: Paul Pak <paulpak58@gmail.com>
Signed-off-by: Rui Qiao <ruisearch42@gmail.com> Signed-off-by: Diego-Castan <diego.castan@ibm.com>
Signed-off-by: Rui Qiao <ruisearch42@gmail.com>
Signed-off-by: Rui Qiao <ruisearch42@gmail.com>
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.Purpose
Higher ray version is required for
ray.experimental.channel.accelerator_contextmodule.Fixes the following issue:
Test Plan
Test Result
(Optional) Documentation Update