Skip to content

Conversation

@ruisearch42
Copy link
Collaborator

@ruisearch42 ruisearch42 commented Aug 2, 2025

Essential Elements of an Effective PR Description Checklist

  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.

Purpose

Higher ray version is required for ray.experimental.channel.accelerator_context module.

Fixes the following issue:

[2025-08-02T07:50:37Z] (EngineCore_0 pid=7101)   File "/usr/local/lib/python3.12/dist-packages/vllm/v1/executor/ray_distributed_executor.py", line 77, in execute_model
[2025-08-02T07:50:37Z] (EngineCore_0 pid=7101)     self.forward_dag = self._compiled_ray_dag(enable_asyncio=False)
[2025-08-02T07:50:37Z] (EngineCore_0 pid=7101)                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[2025-08-02T07:50:37Z] (EngineCore_0 pid=7101)   File "/usr/local/lib/python3.12/dist-packages/vllm/executor/ray_distributed_executor.py", line 612, in _compiled_ray_dag
[2025-08-02T07:50:37Z] (EngineCore_0 pid=7101)     from ray.experimental.channel.accelerator_context import (
[2025-08-02T07:50:37Z] (EngineCore_0 pid=7101) ModuleNotFoundError: No module named 'ray.experimental.channel.accelerator_context'

Test Plan

Test Result

(Optional) Documentation Update

Signed-off-by: Rui Qiao <ruisearch42@gmail.com>
@github-actions
Copy link

github-actions bot commented Aug 2, 2025

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@ruisearch42 ruisearch42 added the ready ONLY add when PR is ready to merge/full CI is needed label Aug 2, 2025
@mergify mergify bot added the ci/build label Aug 2, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request bumps the ray dependency to version 2.48.0 to resolve a ModuleNotFoundError. The change is straightforward and affects the requirements files. My main concern is the lack of a test plan and results in the pull request description. Given that ray is a core dependency, it's crucial to verify that this version bump does not introduce any regressions. I've left a comment requesting the author to provide testing evidence.


# Dependencies for NVIDIA GPUs
ray[cgraph]>=2.43.0, !=2.44.* # Ray Compiled Graph, required for pipeline parallelism in V1.
ray[cgraph]>=2.48.0 # Ray Compiled Graph, required for pipeline parallelism in V1.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Bumping the ray version to 2.48.0 is well-justified to resolve the ModuleNotFoundError.

However, ray is a critical dependency for distributed execution, and version bumps can introduce subtle regressions or performance changes. The pull request description is missing a Test Plan and Test Results, which are essential for a change like this.

To ensure the stability and performance of the project, please:

  1. Run the full test suite, paying close attention to distributed tests that use the ray backend.
  2. Update the pull request description with the test plan and a summary of the results, confirming that all tests pass and there are no performance regressions.

Without this validation, we risk merging a change that could break key functionalities.

@DarkLight1337 DarkLight1337 enabled auto-merge (squash) August 2, 2025 15:48
@vllm-bot vllm-bot merged commit 2ff46b8 into vllm-project:main Aug 3, 2025
76 of 81 checks passed
npanpaliya pushed a commit to odh-on-pz/vllm-upstream that referenced this pull request Aug 6, 2025
Signed-off-by: Rui Qiao <ruisearch42@gmail.com>
jinzhen-lin pushed a commit to jinzhen-lin/vllm that referenced this pull request Aug 9, 2025
Signed-off-by: Rui Qiao <ruisearch42@gmail.com>
Signed-off-by: Jinzhen Lin <linjinzhen@hotmail.com>
noamgat pushed a commit to noamgat/vllm that referenced this pull request Aug 9, 2025
Signed-off-by: Rui Qiao <ruisearch42@gmail.com>
Signed-off-by: Noam Gat <noamgat@gmail.com>
paulpak58 pushed a commit to paulpak58/vllm that referenced this pull request Aug 13, 2025
Signed-off-by: Rui Qiao <ruisearch42@gmail.com>
Signed-off-by: Paul Pak <paulpak58@gmail.com>
diegocastanibm pushed a commit to diegocastanibm/vllm that referenced this pull request Aug 15, 2025
Signed-off-by: Rui Qiao <ruisearch42@gmail.com>
Signed-off-by: Diego-Castan <diego.castan@ibm.com>
epwalsh pushed a commit to epwalsh/vllm that referenced this pull request Aug 28, 2025
Signed-off-by: Rui Qiao <ruisearch42@gmail.com>
zhewenl pushed a commit to zhewenl/vllm that referenced this pull request Aug 28, 2025
Signed-off-by: Rui Qiao <ruisearch42@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci/build ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants