-
-
Notifications
You must be signed in to change notification settings - Fork 11.3k
remove duplicate code within cleanup_dist_env_and_memory #22147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove duplicate code within cleanup_dist_env_and_memory #22147
Conversation
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request removes a redundant call to torch.distributed.destroy_process_group() within the cleanup_dist_env_and_memory function. The call is already made inside destroy_distributed_environment(), which is invoked just before. The change is a good cleanup and improves code clarity by eliminating duplicated logic. The logic appears sound and I don't see any potential issues with this refactoring.
DarkLight1337
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the cleanup!
|
Can you merge from main to see if the CI failure is resolved? |
Signed-off-by: Andy Xie <andy.xning@gmail.com>
Head branch was pushed to by a user without write access
d35f286 to
ee8f7d3
Compare
…t#22147) Signed-off-by: Andy Xie <andy.xning@gmail.com>
…t#22147) Signed-off-by: Andy Xie <andy.xning@gmail.com> Signed-off-by: Jinzhen Lin <linjinzhen@hotmail.com>
…t#22147) Signed-off-by: Andy Xie <andy.xning@gmail.com> Signed-off-by: Noam Gat <noamgat@gmail.com>
…t#22147) Signed-off-by: Andy Xie <andy.xning@gmail.com> Signed-off-by: Paul Pak <paulpak58@gmail.com>
…t#22147) Signed-off-by: Andy Xie <andy.xning@gmail.com> Signed-off-by: Diego-Castan <diego.castan@ibm.com>
…t#22147) Signed-off-by: Andy Xie <andy.xning@gmail.com>
…t#22147) Signed-off-by: Andy Xie <andy.xning@gmail.com>
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.Purpose
The code is duplicated with
destroy_model_parallelinvllm/vllm/distributed/parallel_state.py
Lines 1234 to 1235 in 6d98843
cleanup_dist_env_and_memorywill first calldestroy_model_parallelanddestroy_model_parallelwill calltorch.distributed.destroy_process_group. So, i think the code is duplicated and should be cleaned./cc @comaniac
Test Plan
NA
Test Result
NA
(Optional) Documentation Update
NA