-
-
Notifications
You must be signed in to change notification settings - Fork 11k
[CI Bugfix] Fix wNa16 kernel not found for test_shared_storage_connector_hashes #22163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…tor_hashes Signed-off-by: Tyler Michael Smith <tyler@neuralmagic.com>
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request addresses a CI failure in test_shared_storage_connector_hashes by switching the model used in the test. The original model, using w4a16 quantization, was causing a 'kernel not found' error on CI machines with compute capability 89. The change to a w8a8 quantized model is a direct and appropriate fix, as this quantization scheme is more broadly supported and should resolve the CI issue. The change is minimal, well-justified, and appears correct. I have no further comments.
|
Note: Looking at the history, this test was passing in the CI for a while but then started failing. Did we change the hardware used for the test, or is something truly broken? |
|
I am not aware of any hardware changes |
|
cc @khluu @seemethere do you know anything about this? |
…tor_hashes (vllm-project#22163) Signed-off-by: Tyler Michael Smith <tyler@neuralmagic.com>
…tor_hashes (vllm-project#22163) Signed-off-by: Tyler Michael Smith <tyler@neuralmagic.com> Signed-off-by: Jinzhen Lin <linjinzhen@hotmail.com>
…tor_hashes (vllm-project#22163) Signed-off-by: Tyler Michael Smith <tyler@neuralmagic.com> Signed-off-by: Noam Gat <noamgat@gmail.com>
…tor_hashes (vllm-project#22163) Signed-off-by: Tyler Michael Smith <tyler@neuralmagic.com> Signed-off-by: Paul Pak <paulpak58@gmail.com>
…tor_hashes (vllm-project#22163) Signed-off-by: Tyler Michael Smith <tyler@neuralmagic.com> Signed-off-by: Diego-Castan <diego.castan@ibm.com>
…tor_hashes (vllm-project#22163) Signed-off-by: Tyler Michael Smith <tyler@neuralmagic.com>
…tor_hashes (vllm-project#22163) Signed-off-by: Tyler Michael Smith <tyler@neuralmagic.com>
Purpose
Test is currently failing with:
This PR switches the model for one with that should be more generally well supported.
Test history is here: https://buildkite.com/organizations/vllm/analytics/suites/ci-1/tests/7b01abb7-8064-8f64-9362-7eceb5b9280e?period=7days
Test Plan
Test Result
(Optional) Documentation Update