-
-
Notifications
You must be signed in to change notification settings - Fork 11.1k
[Misc] Clean up duplicated hf overrides #22311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Isotr0py <2037008807@qq.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request effectively refactors duplicated hf_overrides functions into a single, centralized utility, which is a great improvement for maintainability. The implementation correctly consolidates the logic from the previous versions. I've identified a critical issue regarding a potential TypeError and a high-severity issue for improving type hinting in the new utility function. Addressing these will make the new function more robust and the code easier to maintain.
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
DarkLight1337
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the cleanup!
Signed-off-by: Isotr0py <2037008807@qq.com>
Signed-off-by: Isotr0py <2037008807@qq.com>
Signed-off-by: Isotr0py <2037008807@qq.com> Signed-off-by: Jinzhen Lin <linjinzhen@hotmail.com>
Signed-off-by: Isotr0py <2037008807@qq.com> Signed-off-by: Noam Gat <noamgat@gmail.com>
Signed-off-by: Isotr0py <2037008807@qq.com> Signed-off-by: Paul Pak <paulpak58@gmail.com>
Signed-off-by: Isotr0py <2037008807@qq.com> Signed-off-by: Diego-Castan <diego.castan@ibm.com>
Signed-off-by: Isotr0py <2037008807@qq.com>
Signed-off-by: Isotr0py <2037008807@qq.com> Signed-off-by: Xiao Yu <xiao.yu@amd.com>
Signed-off-by: Isotr0py <2037008807@qq.com>
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.Purpose
hf_overridesused to create model with only one layer.Test Plan
Test Result
(Optional) Documentation Update