Skip to content

Conversation

@danielafrimi
Copy link
Contributor

@danielafrimi danielafrimi commented Aug 6, 2025

  1. Heterogeneuous FFN support
  2. Calculate head_dim - Changed from config.expand * config.hidden_size to config.mamba_num_heads * config.mamba_head_dim
  3. Added support for explicit head_dim configuration parameter - Falls back to computed hidden_size // total_num_heads when head_dim is not specified (the models does not force head_dim = hidden_size // total_num_heads

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds support for heterogeneous FFN and explicit head_dim for Nemotron-H models. The changes are well-aligned with the description and seem correct. However, I've identified one critical issue where a parameter with a None default value is used in an operation that would cause a TypeError, which could lead to a runtime crash. I've provided a suggestion to make this parameter required, which should resolve the issue.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As layer_idx can be None, layer_idx + 1 will fail if it's None, adding a guard for layer_idx and ensure hybrid_override_pattern exists before using them would help.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!
change it that now layer_idx cant be None.
for the config.hybrid_override_pattern we do assume that all nemtoronH will have this configuration.

@github-actions
Copy link

github-actions bot commented Aug 6, 2025

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@danielafrimi
Copy link
Contributor Author

CI fails on the a test, listed in CI Failures Dashboard - not cause by my changes

@DarkLight1337 DarkLight1337 added the ready ONLY add when PR is ready to merge/full CI is needed label Aug 10, 2025
@DarkLight1337
Copy link
Member

DarkLight1337 commented Aug 10, 2025

Can you merge from main to fix Hybrid Models test? Also add a test for your model in there

Signed-off-by: Daniel Afrimi <danielafrimi8@gmail.com>

layer_idx cant be None

Signed-off-by: Daniel Afrimi <danielafrimi8@gmail.com>

fix head_dim in config

Signed-off-by: Daniel Afrimi <danielafrimi8@gmail.com>
Copy link
Member

@DarkLight1337 DarkLight1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for supporting this model in vLLM!

@DarkLight1337 DarkLight1337 enabled auto-merge (squash) August 11, 2025 08:41
@vllm-bot vllm-bot merged commit 14a5d90 into vllm-project:main Aug 11, 2025
38 of 44 checks passed
@gournd
Copy link

gournd commented Aug 11, 2025

use vllm-ascend and DeepSeek -V3 -w8a8
(VllmWorker rank=2 pid=55990) INFO 08-11 11:50:32 [quantizer.py:85] Using the vLLM Ascend Quantizer version now!
(VllmWorker rank=3 pid=56719) INFO 08-11 11:50:32 [quantizer.py:85] Using the vLLM Ascend Quantizer version now!
(VllmWorker rank=0 pid=55435) INFO 08-11 11:50:32 [quantizer.py:85] Using the vLLM Ascend Quantizer version now!
(VllmWorker rank=3 pid=56785) INFO 08-11 11:50:32 [quantizer.py:85] Using the vLLM Ascend Quantizer version now!
(VllmWorker rank=0 pid=55436) INFO 08-11 11:50:32 [quantizer.py:85] Using the vLLM Ascend Quantizer version now!
(VllmWorker rank=1 pid=55699) INFO 08-11 11:50:32 [quantizer.py:85] Using the vLLM Ascend Quantizer version now!
(VllmWorker rank=1 pid=55700) INFO 08-11 11:50:32 [quantizer.py:85] Using the vLLM Ascend Quantizer version now!
(VllmWorker rank=2 pid=55990) WARNING 08-11 11:50:32 [config.py:468] MoE DP setup unable to determine quantization scheme or unsupported quantization type. This model will not run with DP enabled.
(VllmWorker rank=3 pid=56719) WARNING 08-11 11:50:32 [config.py:468] MoE DP setup unable to determine quantization scheme or unsupported quantization type. This model will not run with DP enabled.
(VllmWorker rank=0 pid=55435) WARNING 08-11 11:50:32 [config.py:468] MoE DP setup unable to determine quantization scheme or unsupported quantization type. This model will not run with DP enabled.
(VllmWorker rank=2 pid=55989) INFO 08-11 11:50:32 [quantizer.py:85] Using the vLLM Ascend Quantizer version now!

@DarkLight1337
Copy link
Member

Looks like you commented on the wrong PR

paulpak58 pushed a commit to paulpak58/vllm that referenced this pull request Aug 13, 2025
Signed-off-by: Daniel Afrimi <danielafrimi8@gmail.com>
Signed-off-by: Paul Pak <paulpak58@gmail.com>
diegocastanibm pushed a commit to diegocastanibm/vllm that referenced this pull request Aug 15, 2025
Signed-off-by: Daniel Afrimi <danielafrimi8@gmail.com>
Signed-off-by: Diego-Castan <diego.castan@ibm.com>
yiliu30 pushed a commit to yiliu30/vllm-fork that referenced this pull request Aug 19, 2025
Signed-off-by: Daniel Afrimi <danielafrimi8@gmail.com>
epwalsh pushed a commit to epwalsh/vllm that referenced this pull request Aug 28, 2025
Signed-off-by: Daniel Afrimi <danielafrimi8@gmail.com>
xiao-llm pushed a commit to xiao-llm/vllm that referenced this pull request Aug 28, 2025
Signed-off-by: Daniel Afrimi <danielafrimi8@gmail.com>
Signed-off-by: Xiao Yu <xiao.yu@amd.com>
zhewenl pushed a commit to zhewenl/vllm that referenced this pull request Aug 28, 2025
Signed-off-by: Daniel Afrimi <danielafrimi8@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants