Skip to content

Conversation

@lk-chen
Copy link
Collaborator

@lk-chen lk-chen commented Aug 6, 2025

Essential Elements of an Effective PR Description Checklist

  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.

Purpose

FIX #22381

Test Plan

vllm serve Qwen/Qwen2.5-0.5B

vllm bench serve \
    --model Qwen/Qwen2.5-0.5B \
    --percentile-metrics ttft,tpot \
    --save-results

Test Result

(Optional) Documentation Update

Signed-off-by: Linkun <github@lkchen.net>
@github-actions
Copy link

github-actions bot commented Aug 6, 2025

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added the performance Performance-related issues label Aug 6, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request fixes an issue in benchmark/serve.py where saving benchmark results could fail with a KeyError if a metric was not present in the results. The fix correctly adds a check to ensure metrics exist before trying to access them. My review identifies a small area for improvement where a redundant check was added in the extra_info dictionary comprehension. I've suggested removing this redundant check to improve code clarity and maintainability.

Comment on lines 671 to 672
for k in results if (
k not in metrics and k not in ignored_metrics and k in results)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The check k in results is redundant here. The dictionary comprehension already iterates over the keys of the results dictionary with for k in results, so k is guaranteed to be in results. You can simplify this condition to improve code clarity.

            for k in results if k not in metrics and k not in ignored_metrics

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

Signed-off-by: Linkun <github@lkchen.net>
@lk-chen lk-chen requested review from comaniac and ywang96 August 6, 2025 19:11
@lk-chen lk-chen changed the title [bench] Fix benchmark/serve.py to save available results [bench] Fix benchmark/serve.py to only save available results Aug 6, 2025
@lk-chen lk-chen changed the title [bench] Fix benchmark/serve.py to only save available results [bench] Fix benchmark/serve.py to ignore unavailable results Aug 6, 2025
@vllm-bot vllm-bot merged commit 808a7b6 into vllm-project:main Aug 8, 2025
4 of 8 checks passed
@lk-chen lk-chen deleted the vllm_bench_serve_key_error branch August 8, 2025 06:18
ywang96 pushed a commit to ywang96/vllm that referenced this pull request Aug 8, 2025
ywang96 pushed a commit to ywang96/vllm that referenced this pull request Aug 8, 2025
jinzhen-lin pushed a commit to jinzhen-lin/vllm that referenced this pull request Aug 9, 2025
…oject#22382)

Signed-off-by: Linkun <github@lkchen.net>
Signed-off-by: Jinzhen Lin <linjinzhen@hotmail.com>
noamgat pushed a commit to noamgat/vllm that referenced this pull request Aug 9, 2025
…oject#22382)

Signed-off-by: Linkun <github@lkchen.net>
Signed-off-by: Noam Gat <noamgat@gmail.com>
paulpak58 pushed a commit to paulpak58/vllm that referenced this pull request Aug 13, 2025
…oject#22382)

Signed-off-by: Linkun <github@lkchen.net>
Signed-off-by: Paul Pak <paulpak58@gmail.com>
diegocastanibm pushed a commit to diegocastanibm/vllm that referenced this pull request Aug 15, 2025
…oject#22382)

Signed-off-by: Linkun <github@lkchen.net>
Signed-off-by: Diego-Castan <diego.castan@ibm.com>
yiliu30 pushed a commit to yiliu30/vllm-fork that referenced this pull request Aug 19, 2025
epwalsh pushed a commit to epwalsh/vllm that referenced this pull request Aug 28, 2025
xiao-llm pushed a commit to xiao-llm/vllm that referenced this pull request Aug 28, 2025
…oject#22382)

Signed-off-by: Linkun <github@lkchen.net>
Signed-off-by: Xiao Yu <xiao.yu@amd.com>
zhewenl pushed a commit to zhewenl/vllm that referenced this pull request Aug 28, 2025
sducouedic pushed a commit to sducouedic/vllm that referenced this pull request Oct 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

perf-benchmarks performance Performance-related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: vllm bench serve KeyError during saving results, if specifying non-default --percentile-metrics

3 participants