Skip to content

[CI] Skip the pooling models that do not support transformers v4.55 #22411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 7, 2025
Merged

[CI] Skip the pooling models that do not support transformers v4.55 #22411

merged 3 commits into from
Aug 7, 2025

Conversation

@noooop
Copy link
Collaborator

@noooop noooop commented Aug 7, 2025 •
edited by github-actions bot
Loading

Essential Elements of an Effective PR Description Checklist

  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.

Purpose

Qwen/Qwen2.5-Math-PRM-7B hf Implementation does not support v4.54.1

refer to #21931 (comment)

Fix #22398

Test Plan

Test Result

(Optional) Documentation Update

@github-actions
Copy link

github-actions bot commented Aug 7, 2025

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@noooop noooop changed the title [CI] The pooling model is temporarily using transformers 4.53.2 [CI] The pooling model using transformers 4.53.2 temporarily Aug 7, 2025
@mergify mergify bot added the ci/build label Aug 7, 2025
gemini-code-assist[bot]
gemini-code-assist bot reviewed Aug 7, 2025
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This PR pins the transformers library to fix a CI failure. I've suggested adding TODO comments with references to the tracking issue to ensure the temporary pins and test modifications are reverted when the underlying model incompatibility is resolved.

@noooop noooop changed the title [CI] The pooling model using transformers 4.53.2 temporarily [CI] Language Models Test (Extended Pooling) using transformers 4.53.2 temporarily Aug 7, 2025
DarkLight1337
DarkLight1337 reviewed Aug 7, 2025
View reviewed changes
@noooop noooop changed the title [CI] Language Models Test (Extended Pooling) using transformers 4.53.2 temporarily [CI] Skip the pooling models that do not support transformers v4.55 Aug 7, 2025
@noooop
+ check_transformers_version
bf398b4 
Signed-off-by: wang.yuqi <noooop@126.com>
noooop added 2 commits August 7, 2025 10:06
@noooop
fix
1052572 
Signed-off-by: wang.yuqi <noooop@126.com>
@noooop
fix
2ded352 
Signed-off-by: wang.yuqi <noooop@126.com>
DarkLight1337
DarkLight1337 reviewed Aug 7, 2025
View reviewed changes
DarkLight1337
DarkLight1337 approved these changes Aug 7, 2025
View reviewed changes
Copy link
Member

@DarkLight1337 DarkLight1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing

@DarkLight1337 DarkLight1337 enabled auto-merge (squash) August 7, 2025 02:24
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Aug 7, 2025
@vllm-bot vllm-bot merged commit 2a4c825 into vllm-project:main Aug 7, 2025
22 of 26 checks passed
jinzhen-lin pushed a commit to jinzhen-lin/vllm that referenced this pull request Aug 9, 2025
@noooop @jinzhen-lin
[CI] Skip the pooling models that do not support transformers v4.55 (v…
8fb5c56 
…llm-project#22411)

Signed-off-by: wang.yuqi <noooop@126.com>
Signed-off-by: Jinzhen Lin <linjinzhen@hotmail.com>
noamgat pushed a commit to noamgat/vllm that referenced this pull request Aug 9, 2025
@noooop @noamgat
[CI] Skip the pooling models that do not support transformers v4.55 (v…
1dc6060 
…llm-project#22411)

Signed-off-by: wang.yuqi <noooop@126.com>
Signed-off-by: Noam Gat <noamgat@gmail.com>
@noooop noooop deleted the using_4.53 branch August 11, 2025 07:30
paulpak58 pushed a commit to paulpak58/vllm that referenced this pull request Aug 13, 2025
@noooop @paulpak58
[CI] Skip the pooling models that do not support transformers v4.55 (v…
fff6c71 
…llm-project#22411)

Signed-off-by: wang.yuqi <noooop@126.com>
Signed-off-by: Paul Pak <paulpak58@gmail.com>
diegocastanibm pushed a commit to diegocastanibm/vllm that referenced this pull request Aug 15, 2025
@noooop @diegocastanibm
[CI] Skip the pooling models that do not support transformers v4.55 (v…
302766d 
…llm-project#22411)

Signed-off-by: wang.yuqi <noooop@126.com>
Signed-off-by: Diego-Castan <diego.castan@ibm.com>
epwalsh pushed a commit to epwalsh/vllm that referenced this pull request Aug 28, 2025
@noooop @epwalsh
[CI] Skip the pooling models that do not support transformers v4.55 (v…
d2998a1 
…llm-project#22411)

Signed-off-by: wang.yuqi <noooop@126.com>
xiao-llm pushed a commit to xiao-llm/vllm that referenced this pull request Aug 28, 2025
@noooop @amd-xiaoyu12
[CI] Skip the pooling models that do not support transformers v4.55 (v…
11ec1a8 
…llm-project#22411)

Signed-off-by: wang.yuqi <noooop@126.com>
Signed-off-by: Xiao Yu <xiao.yu@amd.com>
zhewenl pushed a commit to zhewenl/vllm that referenced this pull request Aug 28, 2025
@noooop @zhewenl
[CI] Skip the pooling models that do not support transformers v4.55 (v…
4f9d135 
…llm-project#22411)

Signed-off-by: wang.yuqi <noooop@126.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DarkLight1337 DarkLight1337 DarkLight1337 approved these changes

@ywang96 ywang96 Awaiting requested review from ywang96 ywang96 is a code owner

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ci/build ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Milestone

No milestone

3 participants

@noooop @DarkLight1337 @vllm-bot