-
-
Notifications
You must be signed in to change notification settings - Fork 11.8k
[Tool] Fix auto tool call #22434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Tool] Fix auto tool call #22434
Conversation
Signed-off-by: Chen Zhang <zhangch99@outlook.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request refactors the validation for tool usage in the Responses API. The change correctly moves the check for tool support from server initialization to request time, and scopes it to the Responses API for non-Harmony models. This is a good improvement as it prevents the tool-use feature flag from incorrectly blocking other APIs like ChatCompletion at startup. The implementation looks correct and robust. I approve these changes.
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
|
Thanks for fixing |
Signed-off-by: Chen Zhang <zhangch99@outlook.com> Signed-off-by: Jinzhen Lin <linjinzhen@hotmail.com>
Signed-off-by: Chen Zhang <zhangch99@outlook.com> Signed-off-by: Noam Gat <noamgat@gmail.com>
Signed-off-by: Chen Zhang <zhangch99@outlook.com> Signed-off-by: Paul Pak <paulpak58@gmail.com>
Signed-off-by: Chen Zhang <zhangch99@outlook.com> Signed-off-by: Diego-Castan <diego.castan@ibm.com>
Signed-off-by: Chen Zhang <zhangch99@outlook.com>
Signed-off-by: Chen Zhang <zhangch99@outlook.com>
Signed-off-by: Chen Zhang <zhangch99@outlook.com> Signed-off-by: Xiao Yu <xiao.yu@amd.com>
Signed-off-by: Chen Zhang <zhangch99@outlook.com>
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.Purpose
Fix tool call tests in
tests/tool_useTest Plan
Run these tests.
Test Result
test_chat_completions.py::test_chat_completion_without_toolspassed locally. Let's run other tests in CI.(Optional) Documentation Update