Skip to content

Remove from_dict from SpeculativeConfig #22451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 7, 2025
Merged

Remove from_dict from SpeculativeConfig #22451

merged 4 commits into from
Aug 7, 2025

Conversation

@hmellor
Copy link
Member

@hmellor hmellor commented Aug 7, 2025 •
edited by github-actions bot
Loading

Remove from_dict from SpeculativeConfig because it's not necessary for dataclasses

hmellor added 2 commits August 7, 2025 13:06
@hmellor
Remove uneccesary from_dict method from dataclass
f9cac68 
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
@hmellor
Clean up handling of EngineArgs.speculative_config
3c0257e 
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
@github-actions
Copy link

github-actions bot commented Aug 7, 2025

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

gemini-code-assist[bot]
gemini-code-assist bot reviewed Aug 7, 2025
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the handling of SpeculativeConfig to use a dataclass object directly instead of a dictionary, which is a good improvement for type safety and clarity. However, I've identified a critical issue related to the initialization order of SpeculativeConfig that will cause an AttributeError when using speculative decoding configured via CLI. The __post_init__ method of the dataclass is called before all necessary configuration from the engine is available. My review includes a detailed explanation of the issue and a suggested fix.

@hmellor
Review comment
db4c3ac 
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
@hmellor hmellor changed the title Improve handling of SpeculativeConfig in EngineArgs Remove from_dict from SpeculativeConfig Aug 7, 2025
@DarkLight1337 DarkLight1337 enabled auto-merge (squash) August 7, 2025 12:05
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Aug 7, 2025
@DarkLight1337
Copy link
Member

DarkLight1337 commented Aug 7, 2025

PTAL https://buildkite.com/vllm/ci/builds/26248/steps/canvas?sid=0198846c-d11b-4b69-95d3-8774efa11056

@hmellor
Copy link
Member Author

hmellor commented Aug 7, 2025

Ah I reverted too much after Gemini's comment

@hmellor
Fix error
76014b2 
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
yewentao256
yewentao256 approved these changes Aug 7, 2025
View reviewed changes
Copy link
Member

@yewentao256 yewentao256 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks for the work!

@vllm-bot vllm-bot merged commit 7e3a8dc into vllm-project:main Aug 7, 2025
36 of 43 checks passed
@hmellor hmellor deleted the tidy-speculative-config branch August 7, 2025 17:35
jinzhen-lin pushed a commit to jinzhen-lin/vllm that referenced this pull request Aug 9, 2025
@hmellor @jinzhen-lin
Remove from_dict from SpeculativeConfig (vllm-project#22451)
dc8ffbf 
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Signed-off-by: Jinzhen Lin <linjinzhen@hotmail.com>
noamgat pushed a commit to noamgat/vllm that referenced this pull request Aug 9, 2025
@hmellor @noamgat
Remove from_dict from SpeculativeConfig (vllm-project#22451)
3bb565d 
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Signed-off-by: Noam Gat <noamgat@gmail.com>
@LJH-LBJ
Copy link
Contributor

LJH-LBJ commented Aug 11, 2025 •
edited
Loading

I still meet the AttributeError , because the post_init method of the dataclass is called before all necessary configuration from the engine is available. How can I fix it?
image

@hmellor hmellor mentioned this pull request Aug 11, 2025
Merged
@hmellor
Copy link
Member Author

hmellor commented Aug 11, 2025

@LJH-LBJ please try the fix in #22652

@LJH-LBJ
Copy link
Contributor

LJH-LBJ commented Aug 12, 2025

@LJH-LBJ please try the fix in #22652

yes it works, thank you

paulpak58 pushed a commit to paulpak58/vllm that referenced this pull request Aug 13, 2025
@hmellor @paulpak58
Remove from_dict from SpeculativeConfig (vllm-project#22451)
7dc666f 
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Signed-off-by: Paul Pak <paulpak58@gmail.com>
diegocastanibm pushed a commit to diegocastanibm/vllm that referenced this pull request Aug 15, 2025
@hmellor @diegocastanibm
Remove from_dict from SpeculativeConfig (vllm-project#22451)
5910391 
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Signed-off-by: Diego-Castan <diego.castan@ibm.com>
yiliu30 pushed a commit to yiliu30/vllm-fork that referenced this pull request Aug 19, 2025
@hmellor @yiliu30
Remove from_dict from SpeculativeConfig (vllm-project#22451)
6ce0176 
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
epwalsh pushed a commit to epwalsh/vllm that referenced this pull request Aug 28, 2025
@hmellor @epwalsh
Remove from_dict from SpeculativeConfig (vllm-project#22451)
8005dec 
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
xiao-llm pushed a commit to xiao-llm/vllm that referenced this pull request Aug 28, 2025
@hmellor @amd-xiaoyu12
Remove from_dict from SpeculativeConfig (vllm-project#22451)
3fc6ed7 
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Signed-off-by: Xiao Yu <xiao.yu@amd.com>
zhewenl pushed a commit to zhewenl/vllm that referenced this pull request Aug 28, 2025
@hmellor @zhewenl
Remove from_dict from SpeculativeConfig (vllm-project#22451)
8b97dcf 
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yewentao256 yewentao256 yewentao256 approved these changes

@DarkLight1337 DarkLight1337 DarkLight1337 approved these changes

@simon-mo simon-mo Awaiting requested review from simon-mo

@WoosukKwon WoosukKwon Awaiting requested review from WoosukKwon

@youkaichao youkaichao Awaiting requested review from youkaichao

@robertgshaw2-redhat robertgshaw2-redhat Awaiting requested review from robertgshaw2-redhat

@mgoin mgoin Awaiting requested review from mgoin

@tlrmchlsmth tlrmchlsmth Awaiting requested review from tlrmchlsmth

@houseroad houseroad Awaiting requested review from houseroad

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ready ONLY add when PR is ready to merge/full CI is needed speculative-decoding v1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@hmellor @DarkLight1337 @LJH-LBJ @yewentao256 @vllm-bot