-
-
Notifications
You must be signed in to change notification settings - Fork 11k
Frontend: Adding LM Format Enforcer support to V1 engine #22564
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces support for the lm-format-enforcer library as a structured decoding backend for the V1 engine, enhancing parity with the V0 engine. The changes include updating the lm-format-enforcer dependency to a specific version, integrating it into the engine's configuration and processing logic, and adding it to the test suite. The tests have been thoughtfully adapted to accommodate the specific characteristics of this new backend, such as its handling of JSON formatting and its feature set regarding grammar support. The implementation appears solid and follows the established patterns for backend integration within the codebase. I have no major concerns with the proposed changes.
|
The CI fails, but it doesn't look related to my code: Is this a flakiness issue? |
Signed-off-by: Noam Gat <noamgat@gmail.com>
Head branch was pushed to by a user without write access
…t#22564) Signed-off-by: Noam Gat <noamgat@gmail.com> Co-authored-by: Russell Bryant <rbryant@redhat.com> Co-authored-by: Cyrus Leung <tlleungac@connect.ust.hk>
…t#22564) Signed-off-by: Noam Gat <noamgat@gmail.com> Co-authored-by: Russell Bryant <rbryant@redhat.com> Co-authored-by: Cyrus Leung <tlleungac@connect.ust.hk> Signed-off-by: Xiao Yu <xiao.yu@amd.com>
…t#22564) Signed-off-by: Noam Gat <noamgat@gmail.com> Co-authored-by: Russell Bryant <rbryant@redhat.com> Co-authored-by: Cyrus Leung <tlleungac@connect.ust.hk>
…t#22564) Signed-off-by: Noam Gat <noamgat@gmail.com> Co-authored-by: Russell Bryant <rbryant@redhat.com> Co-authored-by: Cyrus Leung <tlleungac@connect.ust.hk>
…t#22564) Signed-off-by: Noam Gat <noamgat@gmail.com> Co-authored-by: Russell Bryant <rbryant@redhat.com> Co-authored-by: Cyrus Leung <tlleungac@connect.ust.hk>
…t#22564) Signed-off-by: Noam Gat <noamgat@gmail.com> Co-authored-by: Russell Bryant <rbryant@redhat.com> Co-authored-by: Cyrus Leung <tlleungac@connect.ust.hk> Signed-off-by: Ekagra Ranjan <3116519+ekagra-ranjan@users.noreply.github.com>
…t#22564) Signed-off-by: Noam Gat <noamgat@gmail.com> Co-authored-by: Russell Bryant <rbryant@redhat.com> Co-authored-by: Cyrus Leung <tlleungac@connect.ust.hk>
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.Purpose
To reduce parity between V0 and V1 and introduce LM Format Enforcer as a structured decoding backend in V1 as well
Test Plan
Added LM Format Enforcer configurations to the structured decoding permutations
Test Result
Tests pass
(Optional) Documentation Update
(Note - this is the same PR as the one I closed, reopened to fix DCO issues)