[CI/Build] Fix tensorizer test for load_format change #22583
Conversation
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates test assertions in tests/tensorizer_loader/test_tensorizer.py to align with a recent change where the LoadFormat enum was replaced with string representations. The modifications correctly update the expected error messages from, for example, LoadFormat.AUTO to auto. The changes are correct and necessary to fix the CI after the refactoring. I have no further comments.
22quinn
requested review from
DarkLight1337,
Isotr0py,
hmellor,
houseroad and
jeejeelee
|
Tensorizer test is still failing, PTAL |
Signed-off-by: 22quinn <33176974+22quinn@users.noreply.github.com>
Signed-off-by: 22quinn <33176974+22quinn@users.noreply.github.com>
22quinn
requested review from
aarnphm,
robertgshaw2-redhat and
simon-mo
as code owners
Fixed now |
…2583) Signed-off-by: 22quinn <33176974+22quinn@users.noreply.github.com> Signed-off-by: Paul Pak <paulpak58@gmail.com>
…2583) Signed-off-by: 22quinn <33176974+22quinn@users.noreply.github.com> Signed-off-by: Diego-Castan <diego.castan@ibm.com>
…2583) Signed-off-by: 22quinn <33176974+22quinn@users.noreply.github.com>
…2583) Signed-off-by: 22quinn <33176974+22quinn@users.noreply.github.com>
…2583) Signed-off-by: 22quinn <33176974+22quinn@users.noreply.github.com> Signed-off-by: Xiao Yu <xiao.yu@amd.com>
…2583) Signed-off-by: 22quinn <33176974+22quinn@users.noreply.github.com>
6 participants
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.Purpose
LoadFormatenum was replaced by strings in #21067 causing a few failuresTest Plan
pytest tests/tensorizer_loader/test_tensorizer.py
Test Result
===================================== 15 passed, 6 warnings in 792.54s (0:13:12) ======================================
(Optional) Documentation Update