-
-
Notifications
You must be signed in to change notification settings - Fork 11.3k
[Misc][gpt-oss] Add rules to label gpt-oss related PRs #22600
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds a new mergify rule to automatically label pull requests related to gpt-oss. The rule conditions look good for matching PR titles and some file paths. However, the file path matching conditions are a bit too restrictive and might miss some relevant files. For example, a file like vllm/reasoning/gptoss_reasoning_parser.py would not be matched by the current rules. I've suggested a change to make the regex more flexible to catch variations like gpt_oss, gpt-oss, and gptoss, and to make it case-insensitive.
Signed-off-by: Lifan Shen <lifans@meta.com>
8fde2b3 to
30c3a8b
Compare
DarkLight1337
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, cc @simon-mo @WoosukKwon I have added gpt-oss label to GH already
…22600) Signed-off-by: Lifan Shen <lifans@meta.com> Signed-off-by: Paul Pak <paulpak58@gmail.com>
…22600) Signed-off-by: Lifan Shen <lifans@meta.com> Signed-off-by: Diego-Castan <diego.castan@ibm.com>
…22600) Signed-off-by: Lifan Shen <lifans@meta.com>
…22600) Signed-off-by: Lifan Shen <lifans@meta.com>
…22600) Signed-off-by: Lifan Shen <lifans@meta.com> Signed-off-by: Xiao Yu <xiao.yu@amd.com>
…22600) Signed-off-by: Lifan Shen <lifans@meta.com>
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.Purpose
Add rules to label gpt-oss related PRs
Test Plan
Test Result