Skip to content

Conversation

@draftbk
Copy link
Contributor

@draftbk draftbk commented Aug 10, 2025

Essential Elements of an Effective PR Description Checklist

  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.

Purpose

Add rules to label gpt-oss related PRs

Test Plan

Test Result

@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added the ci/build label Aug 10, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a new mergify rule to automatically label pull requests related to gpt-oss. The rule conditions look good for matching PR titles and some file paths. However, the file path matching conditions are a bit too restrictive and might miss some relevant files. For example, a file like vllm/reasoning/gptoss_reasoning_parser.py would not be matched by the current rules. I've suggested a change to make the regex more flexible to catch variations like gpt_oss, gpt-oss, and gptoss, and to make it case-insensitive.

Signed-off-by: Lifan Shen <lifans@meta.com>
Copy link
Member

@DarkLight1337 DarkLight1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, cc @simon-mo @WoosukKwon I have added gpt-oss label to GH already

@vllm-bot vllm-bot merged commit 1b99028 into vllm-project:main Aug 11, 2025
13 of 15 checks passed
@mergify mergify bot added the gpt-oss Related to GPT-OSS models label Aug 11, 2025
paulpak58 pushed a commit to paulpak58/vllm that referenced this pull request Aug 13, 2025
…22600)

Signed-off-by: Lifan Shen <lifans@meta.com>
Signed-off-by: Paul Pak <paulpak58@gmail.com>
diegocastanibm pushed a commit to diegocastanibm/vllm that referenced this pull request Aug 15, 2025
…22600)

Signed-off-by: Lifan Shen <lifans@meta.com>
Signed-off-by: Diego-Castan <diego.castan@ibm.com>
yiliu30 pushed a commit to yiliu30/vllm-fork that referenced this pull request Aug 19, 2025
epwalsh pushed a commit to epwalsh/vllm that referenced this pull request Aug 28, 2025
xiao-llm pushed a commit to xiao-llm/vllm that referenced this pull request Aug 28, 2025
…22600)

Signed-off-by: Lifan Shen <lifans@meta.com>
Signed-off-by: Xiao Yu <xiao.yu@amd.com>
zhewenl pushed a commit to zhewenl/vllm that referenced this pull request Aug 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci/build gpt-oss Related to GPT-OSS models

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants