Move SchedulerConfig from config/__init__.py to config/scheduler.py
#22626
Conversation
….py` Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
hmellor
requested review from
WoosukKwon,
houseroad,
mgoin,
robertgshaw2-redhat,
simon-mo,
tlrmchlsmth and
youkaichao
as code owners
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors the SchedulerConfig by moving it from the large vllm/config/__init__.py file into its own dedicated module, vllm/config/scheduler.py. This is a good code organization improvement that increases modularity. The changes correctly handle imports and potential circular dependencies. The refactoring appears to be sound and I did not find any critical or high-severity issues.
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
github-actions
bot
added
the
ready
….py` (vllm-project#22626) Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com> Signed-off-by: Paul Pak <paulpak58@gmail.com>
….py` (vllm-project#22626) Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com> Signed-off-by: Diego-Castan <diego.castan@ibm.com>
….py` (vllm-project#22626) Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
….py` (vllm-project#22626) Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
….py` (vllm-project#22626) Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com> Signed-off-by: Xiao Yu <xiao.yu@amd.com>
….py` (vllm-project#22626) Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
3 participants
Part of #18953