-
-
Notifications
You must be signed in to change notification settings - Fork 11.1k
[Misc] Further clean up some redundant config definitions #22649
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Isotr0py <2037008807@qq.com>
Signed-off-by: Isotr0py <2037008807@qq.com>
Signed-off-by: Isotr0py <2037008807@qq.com>
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
DarkLight1337
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for further simplifying this!
Signed-off-by: Isotr0py <2037008807@qq.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request refactors the model configuration loading by removing several custom configuration classes and introducing a more generic mechanism to override AutoConfig keyword arguments. This is a positive change that simplifies the codebase. However, I have identified two potential issues in vllm/transformers_utils/config.py that are either introduced or exposed by these changes. One is a semantic change in is_encoder_decoder that removes its recursive behavior, which could be problematic for models with nested configurations. The other is a critical issue in _maybe_remap_hf_config_attrs where a sub-configuration is handled as a dictionary instead of a PretrainedConfig object, which will likely cause runtime errors.
Signed-off-by: Isotr0py <2037008807@qq.com>
…ct#22649) Signed-off-by: Isotr0py <2037008807@qq.com> Signed-off-by: Paul Pak <paulpak58@gmail.com>
…ct#22649) Signed-off-by: Isotr0py <2037008807@qq.com> Signed-off-by: Diego-Castan <diego.castan@ibm.com>
…ct#22649) Signed-off-by: Isotr0py <2037008807@qq.com>
…ct#22649) Signed-off-by: Isotr0py <2037008807@qq.com>
…ct#22649) Signed-off-by: Isotr0py <2037008807@qq.com> Signed-off-by: Xiao Yu <xiao.yu@amd.com>
…ct#22649) Signed-off-by: Isotr0py <2037008807@qq.com>
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.Purpose
Related issue: #18850, also cc @princepride
VisionEncoderDecoderConfigused byByteDance/Dolphinenforceshas_no_defaults_at_init=True, so we can't tie it withtrust_remote_code.has_no_defaults_at_initfromtrust_remote_codeand add method to override kwargs when initialize AutoConfig.Test Plan
Test Result
(Optional) Documentation Update