Skip to content

Conversation

@Isotr0py
Copy link
Member

@Isotr0py Isotr0py commented Aug 11, 2025

Essential Elements of an Effective PR Description Checklist

  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.

Purpose

Related issue: #18850, also cc @princepride

  • Some HF config like VisionEncoderDecoderConfig used by ByteDance/Dolphin enforces has_no_defaults_at_init=True, so we can't tie it with trust_remote_code.
  • This PR untie has_no_defaults_at_init from trust_remote_code and add method to override kwargs when initialize AutoConfig.
  • With these changes, we can further clean up some unnecessary config porting.

Test Plan

Test Result

(Optional) Documentation Update

Signed-off-by: Isotr0py <2037008807@qq.com>
Signed-off-by: Isotr0py <2037008807@qq.com>
Signed-off-by: Isotr0py <2037008807@qq.com>
Signed-off-by: Isotr0py <2037008807@qq.com>
@Isotr0py Isotr0py requested a review from DarkLight1337 August 11, 2025 13:29
@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added the llama Related to Llama models label Aug 11, 2025
Copy link
Member

@DarkLight1337 DarkLight1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for further simplifying this!

@DarkLight1337 DarkLight1337 enabled auto-merge (squash) August 11, 2025 13:32
Signed-off-by: Isotr0py <2037008807@qq.com>
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the model configuration loading by removing several custom configuration classes and introducing a more generic mechanism to override AutoConfig keyword arguments. This is a positive change that simplifies the codebase. However, I have identified two potential issues in vllm/transformers_utils/config.py that are either introduced or exposed by these changes. One is a semantic change in is_encoder_decoder that removes its recursive behavior, which could be problematic for models with nested configurations. The other is a critical issue in _maybe_remap_hf_config_attrs where a sub-configuration is handled as a dictionary instead of a PretrainedConfig object, which will likely cause runtime errors.

Signed-off-by: Isotr0py <2037008807@qq.com>
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Aug 11, 2025
@vllm-bot vllm-bot merged commit 8e13d9f into vllm-project:main Aug 11, 2025
42 of 48 checks passed
@Isotr0py Isotr0py deleted the fix-config-default-init branch August 11, 2025 16:27
paulpak58 pushed a commit to paulpak58/vllm that referenced this pull request Aug 13, 2025
…ct#22649)

Signed-off-by: Isotr0py <2037008807@qq.com>
Signed-off-by: Paul Pak <paulpak58@gmail.com>
diegocastanibm pushed a commit to diegocastanibm/vllm that referenced this pull request Aug 15, 2025
…ct#22649)

Signed-off-by: Isotr0py <2037008807@qq.com>
Signed-off-by: Diego-Castan <diego.castan@ibm.com>
yiliu30 pushed a commit to yiliu30/vllm-fork that referenced this pull request Aug 19, 2025
epwalsh pushed a commit to epwalsh/vllm that referenced this pull request Aug 28, 2025
xiao-llm pushed a commit to xiao-llm/vllm that referenced this pull request Aug 28, 2025
…ct#22649)

Signed-off-by: Isotr0py <2037008807@qq.com>
Signed-off-by: Xiao Yu <xiao.yu@amd.com>
zhewenl pushed a commit to zhewenl/vllm that referenced this pull request Aug 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

llama Related to Llama models ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants