Skip to content

Conversation

@hmellor
Copy link
Member

@hmellor hmellor commented Aug 11, 2025

Based on:

This PR:

  • Renames the tp_plan fallback to replicate since this is a valid name in tp_plans
  • Adds explicit support for ReplicatedLinear if the tp_plan contains replicate
  • Adds support for colwise_rep and rowwise_rep by passing the correct arguments to ColumnParallelLinear and RowParallelLinear

This will marginally improve the performance of the following models (if they worked prior to this PR) because layers marked with colwise_rep and rowwise_rep will no longer fall back to ReplicatedLinear:

Models which use colwise_rep Models which use rowwise_rep
image image

Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request extends support for more tensor parallelism styles from HuggingFace Transformers, which is a valuable addition. The implementation correctly maps the new styles (colwise_rep, rowwise_rep, replicate) to the corresponding vLLM linear layer configurations. I have one suggestion to improve robustness by ensuring that any unsupported style in the tp_plan raises an error instead of silently defaulting, which will help prevent hard-to-debug configuration issues.

@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@DarkLight1337
Copy link
Member

Thanks for extending the support!

@DarkLight1337 DarkLight1337 enabled auto-merge (squash) August 11, 2025 14:38
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Aug 11, 2025
@vllm-bot vllm-bot merged commit 458e74e into vllm-project:main Aug 11, 2025
44 of 51 checks passed
@hmellor hmellor deleted the transformers-backend-tp-rep branch August 11, 2025 17:50
paulpak58 pushed a commit to paulpak58/vllm that referenced this pull request Aug 13, 2025
…#22651)

Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Signed-off-by: Paul Pak <paulpak58@gmail.com>
diegocastanibm pushed a commit to diegocastanibm/vllm that referenced this pull request Aug 15, 2025
…#22651)

Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Signed-off-by: Diego-Castan <diego.castan@ibm.com>
yiliu30 pushed a commit to yiliu30/vllm-fork that referenced this pull request Aug 19, 2025
…#22651)

Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
epwalsh pushed a commit to epwalsh/vllm that referenced this pull request Aug 28, 2025
…#22651)

Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
xiao-llm pushed a commit to xiao-llm/vllm that referenced this pull request Aug 28, 2025
…#22651)

Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Signed-off-by: Xiao Yu <xiao.yu@amd.com>
zhewenl pushed a commit to zhewenl/vllm that referenced this pull request Aug 28, 2025
…#22651)

Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
@hmellor hmellor moved this to Done in Transformers backend Sep 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready ONLY add when PR is ready to merge/full CI is needed

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants