-
-
Notifications
You must be signed in to change notification settings - Fork 11.1k
Support more parallel styles in Transformers backend TP #22651
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support more parallel styles in Transformers backend TP #22651
Conversation
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request extends support for more tensor parallelism styles from HuggingFace Transformers, which is a valuable addition. The implementation correctly maps the new styles (colwise_rep, rowwise_rep, replicate) to the corresponding vLLM linear layer configurations. I have one suggestion to improve robustness by ensuring that any unsupported style in the tp_plan raises an error instead of silently defaulting, which will help prevent hard-to-debug configuration issues.
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
|
Thanks for extending the support! |
…#22651) Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com> Signed-off-by: Paul Pak <paulpak58@gmail.com>
…#22651) Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com> Signed-off-by: Diego-Castan <diego.castan@ibm.com>
…#22651) Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
…#22651) Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
…#22651) Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com> Signed-off-by: Xiao Yu <xiao.yu@amd.com>
…#22651) Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Based on:
This PR:
tp_planfallback toreplicatesince this is a valid name intp_plansReplicatedLinearif thetp_plancontainsreplicatecolwise_repandrowwise_repby passing the correct arguments toColumnParallelLinearandRowParallelLinearThis will marginally improve the performance of the following models (if they worked prior to this PR) because layers marked with
colwise_repandrowwise_repwill no longer fall back toReplicatedLinear:colwise_reprowwise_rep