-
-
Notifications
You must be signed in to change notification settings - Fork 11k
[Misc] Fix the benchmark's README and improve the error messages for the benchmark's argument checks #22654
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Misc] Fix the benchmark's README and improve the error messages for the benchmark's argument checks #22654
Conversation
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request correctly fixes incorrect parameters in the benchmark's README examples and improves the clarity of an error message for the benchmark's argument checks. The changes accurately add the --endpoint-type parameter to the examples and update the error message to refer to endpoint-type instead of backend. These changes improve the usability and correctness of the benchmark documentation and error reporting.
3464325 to
91abf64
Compare
…the benchmark's argument checks Signed-off-by: tanruixiang <tanruixiang0104@gmail.com>
91abf64 to
32a4dfa
Compare
|
@DarkLight1337 PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think backend isn't actually used in vllm bench command, can you verify this? If so let's just remove --backend completely
|
@DarkLight1337 It appears to be different from |
|
I am a bit confused by this because I see |
|
Anyway let's merge this first to solve the issue |
|
@DarkLight1337 It seems that the CI error is unrelated to this PR?🤔 |
|
Yeah unrelated, let me force merge |
…the benchmark's argument checks (vllm-project#22654) Signed-off-by: tanruixiang <tanruixiang0104@gmail.com>
…the benchmark's argument checks (vllm-project#22654) Signed-off-by: tanruixiang <tanruixiang0104@gmail.com>
…the benchmark's argument checks (vllm-project#22654) Signed-off-by: tanruixiang <tanruixiang0104@gmail.com>
…the benchmark's argument checks (vllm-project#22654) Signed-off-by: tanruixiang <tanruixiang0104@gmail.com> Signed-off-by: Duncan Moss <djm.moss@gmail.com>
…the benchmark's argument checks (vllm-project#22654) Signed-off-by: tanruixiang <tanruixiang0104@gmail.com>
…the benchmark's argument checks (vllm-project#22654) Signed-off-by: tanruixiang <tanruixiang0104@gmail.com> Signed-off-by: Xiao Yu <xiao.yu@amd.com>
…the benchmark's argument checks (vllm-project#22654) Signed-off-by: tanruixiang <tanruixiang0104@gmail.com>
…the benchmark's argument checks (vllm-project#22654) Signed-off-by: tanruixiang <tanruixiang0104@gmail.com>
…the benchmark's argument checks (vllm-project#22654) Signed-off-by: tanruixiang <tanruixiang0104@gmail.com>
…the benchmark's argument checks (vllm-project#22654) Signed-off-by: tanruixiang <tanruixiang0104@gmail.com>
…the benchmark's argument checks (vllm-project#22654) Signed-off-by: tanruixiang <tanruixiang0104@gmail.com>
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.Purpose
Fix the benchmark's README, the current multimodal-related example parameters are incorrect.
Improve the error messages for the benchmark's argument checks (Currently, the error message incorrectly lists the
--endpoint-typeparameter as--backend)Test Plan
Test Result
(Optional) Documentation Update