Skip to content

Re-enable Xet on TPU tests now that hf_xet has been updated #22666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 12, 2025
Merged

Re-enable Xet on TPU tests now that hf_xet has been updated #22666

merged 1 commit into from
Aug 12, 2025
+2 −5

Conversation

@hmellor
Copy link
Member

@hmellor hmellor commented Aug 11, 2025

Now that we have updated to hf-xet==1.1.7 these environment variables disabling Xet should no longer be necessary.

I'll unblock the TPU tests to verify.

@hmellor
Re-enable Xet on TPU tests now that hf_xet has been updated
9d2b9f7 
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
@github-actions
Copy link

github-actions bot commented Aug 11, 2025

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added the ci/build label Aug 11, 2025
gemini-code-assist[bot]
gemini-code-assist bot reviewed Aug 11, 2025
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request re-enables Xet for TPU tests by removing the HF_HUB_DISABLE_XET=1 environment variable from the CI scripts and a Python test file. The changes are consistent with the goal of verifying the functionality with an updated hf-xet version. The modifications are straightforward and appear correct. I did not find any issues of high or critical severity.

@hmellor hmellor added the ready ONLY add when PR is ready to merge/full CI is needed label Aug 11, 2025
DarkLight1337
DarkLight1337 approved these changes Aug 12, 2025
View reviewed changes
Copy link
Member

@DarkLight1337 DarkLight1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It passes, nice

@vllm-bot vllm-bot merged commit 839ab00 into vllm-project:main Aug 12, 2025
23 of 26 checks passed
@hmellor hmellor deleted the tpu-enable-xet branch August 12, 2025 07:06
paulpak58 pushed a commit to paulpak58/vllm that referenced this pull request Aug 13, 2025
@hmellor @paulpak58
Re-enable Xet on TPU tests now that hf_xet has been updated (vllm-p…
8f87802 
…roject#22666)

Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Signed-off-by: Paul Pak <paulpak58@gmail.com>
diegocastanibm pushed a commit to diegocastanibm/vllm that referenced this pull request Aug 15, 2025
@hmellor @diegocastanibm
Re-enable Xet on TPU tests now that hf_xet has been updated (vllm-p…
df1890d 
…roject#22666)

Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Signed-off-by: Diego-Castan <diego.castan@ibm.com>
yiliu30 pushed a commit to yiliu30/vllm-fork that referenced this pull request Aug 19, 2025
@hmellor @yiliu30
Re-enable Xet on TPU tests now that hf_xet has been updated (vllm-p…
bbb529e 
…roject#22666)

Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
epwalsh pushed a commit to epwalsh/vllm that referenced this pull request Aug 28, 2025
@hmellor @epwalsh
Re-enable Xet on TPU tests now that hf_xet has been updated (vllm-p…
00b6368 
…roject#22666)

Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
xiao-llm pushed a commit to xiao-llm/vllm that referenced this pull request Aug 28, 2025
@hmellor @amd-xiaoyu12
Re-enable Xet on TPU tests now that hf_xet has been updated (vllm-p…
91a884d 
…roject#22666)

Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Signed-off-by: Xiao Yu <xiao.yu@amd.com>
zhewenl pushed a commit to zhewenl/vllm that referenced this pull request Aug 28, 2025
@hmellor @zhewenl
Re-enable Xet on TPU tests now that hf_xet has been updated (vllm-p…
a9118a3 
…roject#22666)

Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DarkLight1337 DarkLight1337 DarkLight1337 approved these changes

@robertgshaw2-redhat robertgshaw2-redhat Awaiting requested review from robertgshaw2-redhat robertgshaw2-redhat is a code owner

@simon-mo simon-mo Awaiting requested review from simon-mo simon-mo is a code owner

@aarnphm aarnphm Awaiting requested review from aarnphm aarnphm is a code owner

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ci/build ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hmellor @DarkLight1337 @vllm-bot