-
-
Notifications
You must be signed in to change notification settings - Fork 11.1k
[DOC] update v1_guide with INTEL HW #22679
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Chendi.Xue <chendi.xue@intel.com>
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the vLLM V1 guide to include information about support for Intel hardware. Specifically, it adds 'INTEL GPU' to the list of supported hardware with a 'functional' status, and adds a link to the vllm-gaudi repository in the list of hardware support plugins. The changes are accurate and correctly reflect the project's support for Intel GPUs via the XPU backend and for Gaudi accelerators via a dedicated plugin/fork. The documentation update is clear and well-placed within the existing structure. I have no major concerns with this change.
DarkLight1337
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for updating
Signed-off-by: Chendi.Xue <chendi.xue@intel.com> Signed-off-by: Paul Pak <paulpak58@gmail.com>
Signed-off-by: Chendi.Xue <chendi.xue@intel.com> Signed-off-by: Diego-Castan <diego.castan@ibm.com>
Signed-off-by: Chendi.Xue <chendi.xue@intel.com>
Signed-off-by: Chendi.Xue <chendi.xue@intel.com>
Signed-off-by: Chendi.Xue <chendi.xue@intel.com> Signed-off-by: Xiao Yu <xiao.yu@amd.com>
Signed-off-by: Chendi.Xue <chendi.xue@intel.com>
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.Purpose
Noticed that V1 document doesn't include Intel GPU and Gaudi information, update with this PR
Test Plan
Test Result
(Optional) Documentation Update