Skip to content

Conversation

zzh142857
Copy link
Contributor

@zzh142857 zzh142857 commented Aug 12, 2025

Essential Elements of an Effective PR Description Checklist

Purpose

Add option to run step3 vision encoder in data parallel manner while the main model is in TP. Can be enabled by flag: vllm_config.parallel_config.enable_multimodal_encoder_data_parallel

Test Plan

Run step3 model and print GPU trace

Test Result

From local benchmark, vision encoder latency can be reduced by ~45%.
Trace before:
Screenshot_2025-08-10_at_11 52 20 AM
Trace after:
Screenshot_2025-08-10_at_11 53 02 AM

E2E benchmark:
Tested e2e with 320 max batch size, QPS has ~10% improvement (from 3.02 to 3.3), TTFT reduced from 3311ms to 3176ms.

(Optional) Documentation Update

Signed-off-by: zzh142857 <chaorenzhaozhenghao@gmail.com>
@zzh142857 zzh142857 changed the title add DP to step3 vision encoder [Model] Add option to run Step3VisionEncoder in DP Aug 12, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces an option to run the step3 vision encoder with data parallelism, which is a great performance enhancement. The implementation is clean and follows existing patterns in the vLLM codebase. The logic for conditionally using ReplicatedLinear for data parallelism and the sharding/gathering of data in run_dp_sharded_vision_model seems correct. The changes are well-contained and properly gated by the new configuration flag. Overall, this is a solid contribution.

Copy link
Member

@DarkLight1337 DarkLight1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM but please fix pre-commit

Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

Signed-off-by: zzh142857 <chaorenzhaozhenghao@gmail.com>
@DarkLight1337
Copy link
Member

DarkLight1337 commented Aug 12, 2025

Thanks. For reference, can you also run E2E benchmarks (benchmark_serving.py) to compare the results?

@DarkLight1337 DarkLight1337 enabled auto-merge (squash) August 12, 2025 17:05
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Aug 12, 2025
@DarkLight1337 DarkLight1337 added this to the v0.10.1 milestone Aug 12, 2025
@simon-mo
Copy link
Collaborator

@DarkLight1337 is this PR good to merge?

@DarkLight1337
Copy link
Member

Yes, you can merge this. The benchmark results can be updated in the PR description later

@DarkLight1337
Copy link
Member

Actually let me just merge this myself

@vllm-bot vllm-bot merged commit d16aa3d into vllm-project:main Aug 13, 2025
45 of 53 checks passed
diegocastanibm pushed a commit to diegocastanibm/vllm that referenced this pull request Aug 15, 2025
Signed-off-by: zzh142857 <chaorenzhaozhenghao@gmail.com>
Signed-off-by: Diego-Castan <diego.castan@ibm.com>
yiliu30 pushed a commit to yiliu30/vllm-fork that referenced this pull request Aug 19, 2025
Signed-off-by: zzh142857 <chaorenzhaozhenghao@gmail.com>
divakar-amd pushed a commit to divakar-amd/vllm_upstream that referenced this pull request Aug 20, 2025
Signed-off-by: zzh142857 <chaorenzhaozhenghao@gmail.com>
epwalsh pushed a commit to epwalsh/vllm that referenced this pull request Aug 28, 2025
Signed-off-by: zzh142857 <chaorenzhaozhenghao@gmail.com>
xiao-llm pushed a commit to xiao-llm/vllm that referenced this pull request Aug 28, 2025
Signed-off-by: zzh142857 <chaorenzhaozhenghao@gmail.com>
Signed-off-by: Xiao Yu <xiao.yu@amd.com>
zhewenl pushed a commit to zhewenl/vllm that referenced this pull request Aug 28, 2025
Signed-off-by: zzh142857 <chaorenzhaozhenghao@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants