Skip to content

Conversation

@NickLucche
Copy link
Collaborator

@NickLucche NickLucche commented Aug 13, 2025

Fix:

[2025-08-13T12:15:17Z] ________ ERROR collecting tests/v1/e2e/test_kv_sharing_fast_prefill.py _________
[2025-08-13T12:15:17Z] ImportError while importing test module '/vllm-workspace/tests/v1/e2e/test_kv_sharing_fast_prefill.py'.
[2025-08-13T12:15:17Z] Hint: make sure your test modules/packages have valid Python names.
[2025-08-13T12:15:17Z] Traceback:
[2025-08-13T12:15:17Z] /usr/lib/python3.12/importlib/__init__.py:90: in import_module
[2025-08-13T12:15:17Z]     return _bootstrap._gcd_import(name[level:], package, level)
[2025-08-13T12:15:17Z] v1/e2e/test_kv_sharing_fast_prefill.py:14: in <module>
[2025-08-13T12:15:17Z]     from vllm.model_executor.models.gemma3n import Gemma3nForConditionalGeneration
[2025-08-13T12:15:17Z] E   ImportError: cannot import name 'Gemma3nForConditionalGeneration' from 'vllm.model_executor.models.gemma3n' (/usr/local/lib/python3.12/dist-packages/vllm/model_executor/models/gemma3n.py)

now:

.                                                                                                 [100%]
=========================================== warnings summary ============================================
<frozen importlib._bootstrap>:488
  <frozen importlib._bootstrap>:488: DeprecationWarning: builtin type SwigPyPacked has no __module__ attribute

<frozen importlib._bootstrap>:488
  <frozen importlib._bootstrap>:488: DeprecationWarning: builtin type SwigPyObject has no __module__ attribute

tests/v1/e2e/test_kv_sharing_fast_prefill.py:26
  /home/nicolo/llmd/vllm/tests/v1/e2e/test_kv_sharing_fast_prefill.py:26: PytestCollectionWarning: cannot collect test class 'TestGemma3nForConditionalGeneration' because it has a __init__ constructor (from: tests/v1/e2e/test_kv_sharing_fast_prefill.py)
    class TestGemma3nForConditionalGeneration(Gemma3nForConditionalGeneration):

tests/v1/e2e/test_kv_sharing_fast_prefill.py::test_kv_sharing_fast_prefill[True]
  /home/nicolo/llmd/vllm/tests/utils.py:749: DeprecationWarning: This process (pid=114578) is multi-threaded, use of fork() may lead to deadlocks in the child.
    pid = os.fork()

-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html
1 passed, 4 warnings in 40.07s
sys:1: DeprecationWarning: builtin type swigvarlink has no __module__ attribute

by having the test run the newly added gemma3n-mm.

Signed-off-by: NickLucche <nlucches@redhat.com>
@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added the v1 label Aug 13, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly fixes an ImportError in tests/v1/e2e/test_kv_sharing_fast_prefill.py. The error was caused by attempting to import Gemma3nForConditionalGeneration from the wrong module. The change updates the import path to vllm.model_executor.models.gemma3n_mm, which is the correct location for this class. This is a necessary fix to resolve the CI failure, and the implementation is correct.

@NickLucche NickLucche marked this pull request as draft August 13, 2025 13:32
Signed-off-by: NickLucche <nlucches@redhat.com>
@NickLucche NickLucche marked this pull request as ready for review August 13, 2025 13:43
Copy link
Member

@DarkLight1337 DarkLight1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing!

@DarkLight1337 DarkLight1337 enabled auto-merge (squash) August 13, 2025 13:44
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Aug 13, 2025
@DarkLight1337
Copy link
Member

There is another test failing about spec decoding

@vllm-bot vllm-bot merged commit 12817a8 into vllm-project:main Aug 13, 2025
20 of 23 checks passed
yiliu30 pushed a commit to yiliu30/vllm-fork that referenced this pull request Aug 19, 2025
divakar-amd pushed a commit to divakar-amd/vllm_upstream that referenced this pull request Aug 20, 2025
epwalsh pushed a commit to epwalsh/vllm that referenced this pull request Aug 28, 2025
xiao-llm pushed a commit to xiao-llm/vllm that referenced this pull request Aug 28, 2025
vllm-project#22815)

Signed-off-by: NickLucche <nlucches@redhat.com>
Signed-off-by: Xiao Yu <xiao.yu@amd.com>
zhewenl pushed a commit to zhewenl/vllm that referenced this pull request Aug 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready ONLY add when PR is ready to merge/full CI is needed v1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants