-
-
Notifications
You must be signed in to change notification settings - Fork 11.3k
[CI] Fix tests/v1/e2e/test_kv_sharing_fast_prefill.py import on test
#22815
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: NickLucche <nlucches@redhat.com>
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request correctly fixes an ImportError in tests/v1/e2e/test_kv_sharing_fast_prefill.py. The error was caused by attempting to import Gemma3nForConditionalGeneration from the wrong module. The change updates the import path to vllm.model_executor.models.gemma3n_mm, which is the correct location for this class. This is a necessary fix to resolve the CI failure, and the implementation is correct.
Signed-off-by: NickLucche <nlucches@redhat.com>
DarkLight1337
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing!
|
There is another test failing about spec decoding |
vllm-project#22815) Signed-off-by: NickLucche <nlucches@redhat.com>
vllm-project#22815) Signed-off-by: NickLucche <nlucches@redhat.com>
vllm-project#22815) Signed-off-by: NickLucche <nlucches@redhat.com>
vllm-project#22815) Signed-off-by: NickLucche <nlucches@redhat.com> Signed-off-by: Xiao Yu <xiao.yu@amd.com>
vllm-project#22815) Signed-off-by: NickLucche <nlucches@redhat.com>
Fix:
now:
by having the test run the newly added gemma3n-mm.