[BugFix] Fix stuck stats/metrics after requests are aborted #22995
Conversation
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request aims to fix an issue where scheduler statistics could get stuck if all requests in a step are aborted. The proposed change ensures that stats are always returned, even if there are no other engine outputs.
However, the implementation contains a critical bug related to operator precedence with the walrus operator (:=). In its current form, the code will either raise an AttributeError or cause a type error. I've provided a suggestion to fix this by adding the necessary parentheses to correctly capture the intended values before comparison.
Signed-off-by: Nick Hill <nhill@redhat.com>
njhill
force-pushed
the
fix-abort-metrics
branch
from
8f5edce to
dc3b867
Compare
njhill
requested review from
WoosukKwon,
alexm-redhat,
comaniac,
robertgshaw2-redhat and
ywang96
as code owners
Signed-off-by: Nick Hill <nhill@redhat.com>
njhill
requested review from
DarkLight1337,
aarnphm and
simon-mo
as code owners
Signed-off-by: Nick Hill <nhill@redhat.com>
DarkLight1337
left a comment
DarkLight1337
left a comment
There was a problem hiding this comment.
Thanks for fixing! The test passes so it should be good
…ject#22995) Signed-off-by: Nick Hill <nhill@redhat.com>
…ject#22995) Signed-off-by: Nick Hill <nhill@redhat.com>
…ject#22995) Signed-off-by: Nick Hill <nhill@redhat.com> Signed-off-by: Duncan Moss <djm.moss@gmail.com>
…ject#22995) Signed-off-by: Nick Hill <nhill@redhat.com>
…ject#22995) Signed-off-by: Nick Hill <nhill@redhat.com> Signed-off-by: Xiao Yu <xiao.yu@amd.com>
…ject#22995) Signed-off-by: Nick Hill <nhill@redhat.com>
…ject#22995) Signed-off-by: Nick Hill <nhill@redhat.com>
…ject#22995) Signed-off-by: Nick Hill <nhill@redhat.com>
…ject#22995) Signed-off-by: Nick Hill <nhill@redhat.com>
2 participants
Ensure that we always return new stats from scheduler.
Includes small fix to block pool to exclude null block when calculating cache usage percentage.
Fixes #22545.