[Misc] Convert use_structured_output property into constant #23060
Conversation
Signed-off-by: Woosuk Kwon <woosuk.kwon@berkeley.edu>
WoosukKwon
requested review from
alexm-redhat,
comaniac,
njhill,
robertgshaw2-redhat and
ywang96
as code owners
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request correctly converts the use_structured_output property into an instance attribute to improve performance by avoiding repeated property evaluation. My review includes a suggestion to refactor the newly added logic to improve conciseness and address a code duplication issue, which will enhance maintainability.
…ject#23060) Signed-off-by: Woosuk Kwon <woosuk.kwon@berkeley.edu>
…ject#23060) Signed-off-by: Woosuk Kwon <woosuk.kwon@berkeley.edu>
…ject#23060) Signed-off-by: Woosuk Kwon <woosuk.kwon@berkeley.edu> Signed-off-by: Duncan Moss <djm.moss@gmail.com>
…ject#23060) Signed-off-by: Woosuk Kwon <woosuk.kwon@berkeley.edu>
…ject#23060) Signed-off-by: Woosuk Kwon <woosuk.kwon@berkeley.edu> Signed-off-by: Xiao Yu <xiao.yu@amd.com>
…ject#23060) Signed-off-by: Woosuk Kwon <woosuk.kwon@berkeley.edu>
1 participant
This PR converts
use_structured_outputproperty ofRequestclass into a constant, which will help avoid unnecessary Python overheads.