[BugFix] Fix MinPLogitsProcessor.update_states()
#23401
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
min_p_count was not updated correctly for added requests. Signed-off-by: Nick Hill <nhill@redhat.com>
njhill
requested review from
WoosukKwon,
alexm-redhat,
comaniac,
robertgshaw2-redhat and
ywang96
as code owners
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request addresses a bug in MinPLogitsProcessor.update_states() where min_p_count was incorrectly updated for added requests. The fix correctly adjusts the count based on whether a request with a non-zero min_p is added to a slot that previously had a zero min_p, and vice-versa. Additionally, the code for handling moved requests has been simplified for better readability. The changes are correct and improve the robustness of the logits processor.
Signed-off-by: Nick Hill <nhill@redhat.com>
njhill
changed the title
MinPLogitsProcessor.update_states()MinPLogitsProcessor.update_states()
DarkLight1337
approved these changes
Aug 23, 2025
epwalsh
pushed a commit
to epwalsh/vllm
that referenced
this pull request
Aug 28, 2025
Signed-off-by: Nick Hill <nhill@redhat.com>
xiao-llm
pushed a commit
to xiao-llm/vllm
that referenced
this pull request
Aug 28, 2025
Signed-off-by: Nick Hill <nhill@redhat.com> Signed-off-by: Xiao Yu <xiao.yu@amd.com>
zhewenl
pushed a commit
to zhewenl/vllm
that referenced
this pull request
Aug 28, 2025
Signed-off-by: Nick Hill <nhill@redhat.com>
mengxingkongzhouhan
pushed a commit
to mengxingkongzhouhan/vllm
that referenced
this pull request
Aug 30, 2025
Signed-off-by: Nick Hill <nhill@redhat.com>
zhewenl
pushed a commit
to zhewenl/vllm
that referenced
this pull request
Sep 3, 2025
Signed-off-by: Nick Hill <nhill@redhat.com>
ekagra-ranjan
pushed a commit
to ekagra-ranjan/vllm
that referenced
this pull request
Sep 4, 2025
Signed-off-by: Nick Hill <nhill@redhat.com> Signed-off-by: Ekagra Ranjan <3116519+ekagra-ranjan@users.noreply.github.com>
FeiDaLI
pushed a commit
to FeiDaLI/vllm
that referenced
this pull request
Sep 25, 2025
Signed-off-by: Nick Hill <nhill@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
min_p_countwas not updated correctly for replaced requests.cc @afeldman-nm