-
-
Notifications
You must be signed in to change notification settings - Fork 11.4k
DP/EP Support for gpt-oss with deepep-ht comm kernel on SM100 #23608
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 6 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
6864bf0
fixes
f3ea857
fixe
7aad7b8
temp fix
zyongye 87f1cea
cleanup
zyongye 665966d
format
zyongye 1df5aa2
comment
zyongye f8775df
nit
zyongye 2143639
nit
zyongye 02521ae
Merge remote-tracking branch 'upstream/main' into gptoss-deepep-ht
zyongye File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,197 @@ | ||
| # SPDX-License-Identifier: Apache-2.0 | ||
| # SPDX-FileCopyrightText: Copyright contributors to the vLLM project | ||
| from typing import Optional | ||
|
|
||
| import torch | ||
|
|
||
| import vllm.model_executor.layers.fused_moe.modular_kernel as mk | ||
| from vllm.model_executor.layers.fused_moe.config import FusedMoEConfig | ||
| from vllm.model_executor.layers.fused_moe.topk_weight_and_reduce import ( | ||
| TopKWeightAndReduceNoOP) | ||
| from vllm.utils import next_power_of_2 | ||
|
|
||
|
|
||
| class TrtLlmGenExperts(mk.FusedMoEPermuteExpertsUnpermute): | ||
|
|
||
| def __init__( | ||
| self, | ||
| moe: FusedMoEConfig, | ||
| gemm1_alpha, | ||
| gemm1_beta, | ||
| gemm1_clamp_limit, | ||
| w13_bias, | ||
| w2_bias, | ||
| max_capture_size, | ||
|
Comment on lines
+19
to
+24
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Missing types |
||
| ): | ||
| super().__init__(moe.quant_config) | ||
| self.moe = moe | ||
| self.gemm1_alpha = gemm1_alpha | ||
| self.gemm1_beta = gemm1_beta | ||
| self.gemm1_clamp_limit = gemm1_clamp_limit | ||
| self.w13_bias = w13_bias | ||
| self.w2_bias = w2_bias | ||
| self.max_capture_size = max_capture_size | ||
|
|
||
| @property | ||
| def activation_formats( | ||
| self | ||
| ) -> tuple[mk.FusedMoEActivationFormat, mk.FusedMoEActivationFormat]: | ||
| return (mk.FusedMoEActivationFormat.Standard, | ||
| mk.FusedMoEActivationFormat.Standard) | ||
|
|
||
| def supports_chunking(self) -> bool: | ||
| return True | ||
|
|
||
| def supports_expert_map(self) -> bool: | ||
| return True | ||
|
|
||
| def finalize_weight_and_reduce_impl(self) -> mk.TopKWeightAndReduce: | ||
| return TopKWeightAndReduceNoOP() | ||
|
|
||
| def workspace_shapes( | ||
| self, | ||
| a: torch.Tensor, | ||
| aq: torch.Tensor, | ||
| M: int, | ||
| N: int, | ||
| K: int, | ||
| topk: int, | ||
| global_num_experts: int, | ||
| local_num_experts: int, | ||
| expert_tokens_meta: Optional[mk.ExpertTokensMetadata], | ||
| ) -> tuple[tuple[int, ...], tuple[int, ...], tuple[int, ...], torch.dtype]: | ||
| # The workspaces for this implementation are managed by flashinfer. | ||
| # TODO(varun) : workspace1 is could be used as the output tensor. This | ||
| # is error-prone. Allow the `workspace_shapes` to return None workspaces | ||
| workspace1 = (M, K) | ||
| workspace2 = (0, 0) | ||
| output = (M, K) | ||
| return (workspace1, workspace2, output, a.dtype) | ||
|
|
||
| def _get_tile_tokens_dim(self, x: torch.Tensor, top_k: int, | ||
| local_num_experts: int): | ||
| # Number of tokens in the input tensor. | ||
| num_tokens = x.shape[0] | ||
| # Factor to account for the imbalance of the experts. | ||
| # factor equals to the | ||
| # max_real_num_tokens_per_expert / perfect_num_tokens_per_expert | ||
| # 1.0 means perfect expert distribution. | ||
| # > 1.0 means some experts have more tokens than the perfect | ||
| # distribution. | ||
| # < 1.0 does not make sense. | ||
| imbalance_factor = 1.3 | ||
| # Calculate the number of tokens per expert assuming perfect | ||
| # distribution. | ||
| num_tokens_per_expert = (num_tokens * top_k) // local_num_experts | ||
| # Apply the imbalance factor. | ||
| num_tokens_per_expert = int(num_tokens_per_expert * imbalance_factor) | ||
| # And pad the number to the next power of 2. | ||
| tile_tokens_dim = next_power_of_2(num_tokens_per_expert) | ||
| # Cap to 8-64 tokens per CTA tile as it's the range supported by the | ||
| # kernel. | ||
| tile_tokens_dim = min(max(tile_tokens_dim, 8), 64) | ||
|
|
||
| return tile_tokens_dim | ||
|
|
||
| def apply( | ||
| self, | ||
| output: torch.Tensor, | ||
| hidden_states: torch.Tensor, | ||
| w1: torch.Tensor, | ||
| w2: torch.Tensor, | ||
| topk_weights: torch.Tensor, | ||
| topk_ids: torch.Tensor, | ||
| activation: str, | ||
| global_num_experts: int, | ||
| expert_map: Optional[torch.Tensor], | ||
| w1_scale: Optional[torch.Tensor], | ||
| w2_scale: Optional[torch.Tensor], | ||
| w1_zp: Optional[torch.Tensor], | ||
| w2_zp: Optional[torch.Tensor], | ||
| a1q_scale: Optional[torch.Tensor], | ||
| a2_scale: Optional[torch.Tensor], | ||
| workspace13: torch.Tensor, | ||
| workspace2: torch.Tensor, | ||
| expert_tokens_meta: Optional[mk.ExpertTokensMetadata], | ||
| apply_router_weight_on_input: bool, | ||
| ): | ||
| topk = topk_ids.size(-1) | ||
| local_num_experts = w1.size(0) | ||
| intermediate_size = w2.size(1) | ||
| local_expert_offset = self.moe.ep_rank * local_num_experts | ||
|
|
||
| x_quant = hidden_states | ||
| x_scale = a1q_scale | ||
| if x_scale is not None: | ||
| x_scale = x_scale.view(torch.float8_e4m3fn).reshape( | ||
| *x_quant.shape[:-1], -1) | ||
|
|
||
| packed_tensor = (topk_ids.to(torch.int32) << 16) | topk_weights.to( | ||
| torch.bfloat16).view(torch.int16) | ||
|
|
||
| assert w1_scale is not None | ||
| assert w2_scale is not None | ||
| kwargs = { | ||
| "topk_ids": | ||
| packed_tensor, | ||
| "routing_bias": | ||
| None, | ||
| "hidden_states": | ||
| x_quant, | ||
| "hidden_states_scale": | ||
| x_scale, | ||
| "gemm1_weights": | ||
| w1, | ||
| "gemm1_weights_scale": | ||
| w1_scale, | ||
| "gemm1_bias": | ||
| self.w13_bias, | ||
| "gemm1_alpha": | ||
| self.gemm1_alpha, | ||
| "gemm1_beta": | ||
| self.gemm1_beta, | ||
| "gemm1_clamp_limit": | ||
| self.gemm1_clamp_limit, | ||
| "gemm2_weights": | ||
| w2, | ||
| "gemm2_weights_scale": | ||
| w2_scale, | ||
| "gemm2_bias": | ||
| self.w2_bias, | ||
| "output1_scale_scalar": | ||
| None, | ||
| "output1_scale_gate_scalar": | ||
| None, | ||
| "output2_scale_scalar": | ||
| None, | ||
| "num_experts": | ||
| global_num_experts, | ||
| "top_k": | ||
| topk, | ||
| "n_group": | ||
| None, | ||
| "topk_group": | ||
| None, | ||
| "intermediate_size": | ||
| intermediate_size, | ||
| "local_expert_offset": | ||
| local_expert_offset, | ||
| "local_num_experts": | ||
| local_num_experts, | ||
| "routed_scaling_factor": | ||
| None, | ||
| "tile_tokens_dim": | ||
| self._get_tile_tokens_dim(x_quant, topk, local_num_experts), | ||
| "routing_method_type": | ||
| 1, | ||
| "do_finalize": | ||
| True, | ||
| "output": | ||
| output, | ||
| "tune_max_num_tokens": | ||
| self.max_capture_size, | ||
| } | ||
|
|
||
| from flashinfer import trtllm_fp4_block_scale_routed_moe | ||
| trtllm_fp4_block_scale_routed_moe(**kwargs) | ||
| return output | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -3,7 +3,7 @@ | |
|
|
||
| import enum | ||
| from enum import Enum | ||
| from typing import Callable, Optional | ||
| from typing import Any, Callable, Optional | ||
|
|
||
| import torch | ||
| from compressed_tensors import CompressionFormat | ||
|
|
@@ -292,6 +292,7 @@ def select_gemm_impl( | |
| self, | ||
| prepare_finalize: mk.FusedMoEPrepareAndFinalize, | ||
| moe: FusedMoEConfig, | ||
| layer: Any, | ||
|
||
| ) -> mk.FusedMoEPermuteExpertsUnpermute: | ||
| """Return the appropriate GEMM experts implementation.""" | ||
| experts = select_nvfp4_gemm_impl( | ||
|
|
@@ -688,11 +689,9 @@ def process_weights_after_loading(self, layer: torch.nn.Module) -> None: | |
| device=device, | ||
| dtype=torch.int64) | ||
|
|
||
| def select_gemm_impl( | ||
| self, | ||
| prepare_finalize: FusedMoEPrepareAndFinalize, | ||
| moe: FusedMoEConfig, | ||
| ) -> FusedMoEPermuteExpertsUnpermute: | ||
| def select_gemm_impl(self, prepare_finalize: FusedMoEPrepareAndFinalize, | ||
| moe: FusedMoEConfig, | ||
| layer: Any) -> FusedMoEPermuteExpertsUnpermute: | ||
| # cutlass path | ||
| if self.use_cutlass: | ||
| from vllm.model_executor.layers.fused_moe import ( | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.