[Model] fix DeepSeek e_score_correction_bias dtype to fp32 #23640
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youkaichao
approved these changes
Aug 26, 2025
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request correctly addresses a data type issue for the e_score_correction_bias parameter in DeepSeek V3 models. By explicitly setting the dtype to torch.float32 during tensor creation, the change ensures that the parameter's data type matches the precision of the model weights. This prevents potential dtype mismatches and precision loss that could occur during weight loading, especially when the default PyTorch dtype is set to a lower precision format like float16. The fix is accurate, well-targeted, and necessary for the correct operation of DeepSeek V3 models.
youkaichao
changed the title
tc-mb
pushed a commit
to tc-mb/vllm
that referenced
this pull request
Aug 27, 2025
…ect#23640) Signed-off-by: Jee Jee Li <pandaleefree@gmail.com> Signed-off-by: tc-mb <caitianchi@modelbest.cn>
epwalsh
pushed a commit
to epwalsh/vllm
that referenced
this pull request
Aug 28, 2025
…ect#23640) Signed-off-by: Jee Jee Li <pandaleefree@gmail.com>
xiao-llm
pushed a commit
to xiao-llm/vllm
that referenced
this pull request
Aug 28, 2025
…ect#23640) Signed-off-by: Jee Jee Li <pandaleefree@gmail.com> Signed-off-by: Xiao Yu <xiao.yu@amd.com>
zhewenl
pushed a commit
to zhewenl/vllm
that referenced
this pull request
Aug 28, 2025
…ect#23640) Signed-off-by: Jee Jee Li <pandaleefree@gmail.com>
zhewenl
pushed a commit
to zhewenl/vllm
that referenced
this pull request
Sep 3, 2025
…ect#23640) Signed-off-by: Jee Jee Li <pandaleefree@gmail.com>
FeiDaLI
pushed a commit
to FeiDaLI/vllm
that referenced
this pull request
Sep 25, 2025
…ect#23640) Signed-off-by: Jee Jee Li <pandaleefree@gmail.com>
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
The
e_score_correction_biasweights of the deepseek v3 model are FP32Test Plan
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.