Skip to content

Conversation

@wdhongtw
Copy link
Contributor

@wdhongtw wdhongtw commented Aug 26, 2025

Each iteration of OOM execution when finding max available memory-utilization results in 10 min delay.
Try to detect crashed situation and continue to next iteration efficiently.

Purpose

Currently when auto_tune.sh is scanning max available value of memory-utilization,
it takes unnecessary time and it's kinda confusing. Since that user usually sees no
child process in that bash session for about 10 * N min. N is the number of iterations
until finding the available value.

This PR help reducing this confusing situation and enhance the efficiency by proactively
detects the OOM situation and continue to next iteration.

Test Plan

No test plan for this change, as this PR is related to helper script.

Test Result

N/A


Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
  • (Optional) Release notes update. If your change is user facing, please update the release notes draft in the Google Doc.

Each iteration of OOM execution when finding max available memory-utilization
results in 10 min delay.
Try to detect crashed situation and continue to next iteration efficiently.

Signed-off-by: Weida Hong <wdhongtw@google.com>
@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors.

You ask your reviewers to trigger select CI tests on top of fastcheck CI.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

If you have any questions, please reach out to us on Slack at https://slack.vllm.ai.

🚀

@mergify mergify bot added the performance Performance-related issues label Aug 26, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request improves the auto_tune.sh script by detecting server crashes early, which reduces unnecessary delays during the auto-tuning process. The approach of checking the server's process ID is sound. However, it could be made more robust to prevent potential issues with PID reuse, which could lead to incorrect benchmark results. I've suggested a small change to also verify the process command line, making the check more reliable.

Copy link
Contributor

@Chenyaaang Chenyaaang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the improvement!

Copy link
Collaborator

@yaochengji yaochengji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the improvement!

@yaochengji yaochengji enabled auto-merge (squash) September 23, 2025 16:14
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Sep 23, 2025
@yaochengji yaochengji merged commit 24e8222 into vllm-project:main Sep 23, 2025
27 checks passed
FeiDaLI pushed a commit to FeiDaLI/vllm that referenced this pull request Sep 25, 2025
Signed-off-by: Weida Hong <wdhongtw@google.com>
yewentao256 pushed a commit that referenced this pull request Oct 3, 2025
Signed-off-by: Weida Hong <wdhongtw@google.com>
Signed-off-by: yewentao256 <zhyanwentao@126.com>
gjc0824 pushed a commit to gjc0824/vllm that referenced this pull request Oct 10, 2025
Signed-off-by: Weida Hong <wdhongtw@google.com>
Signed-off-by: gaojc <1055866782@qq.com>
xuebwang-amd pushed a commit to xuebwang-amd/vllm that referenced this pull request Oct 10, 2025
Signed-off-by: Weida Hong <wdhongtw@google.com>
Signed-off-by: xuebwang-amd <xuebwang@amd.com>
choprahetarth pushed a commit to Tandemn-Labs/vllm that referenced this pull request Oct 11, 2025
Signed-off-by: Weida Hong <wdhongtw@google.com>
lywa1998 pushed a commit to lywa1998/vllm that referenced this pull request Oct 20, 2025
Signed-off-by: Weida Hong <wdhongtw@google.com>
xuebwang-amd pushed a commit to xuebwang-amd/vllm that referenced this pull request Oct 24, 2025
Signed-off-by: Weida Hong <wdhongtw@google.com>
Signed-off-by: xuebwang-amd <xuebwang@amd.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

performance Performance-related issues ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants