Skip to content

Conversation

@Zerohertz
Copy link
Contributor

@Zerohertz Zerohertz commented Aug 27, 2025

Continued #23649


Note

Warnings fixed:

WARNING -  griffe: vllm/core/block/naive_block.py:210: Failed to get 'name: description' pair from 'in whole allocator.'
WARNING -  griffe: vllm/core/block/prefix_caching_block.py:64: Parameter 'block_ids(Optional[Iterable[int]],' does not appear in the function signature

WARNING -  griffe: vllm/core/scheduler.py:660: Failed to get 'name: description' pair from 'that are currently running'

WARNING -  griffe: vllm/v1/attention/backends/flash_attn.py:441: Failed to get 'name: description' pair from 'kv_cache = [2, num_blocks, block_size, num_kv_heads, head_size]'

WARNING -  griffe: vllm/v1/attention/backends/flashinfer.py:641: Parameter '#' does not appear in the function signature
WARNING -  griffe: vllm/v1/attention/backends/flashinfer.py:642: Parameter '#' does not appear in the function signature

WARNING -  griffe: vllm/v1/worker/utils.py:280: Failed to get 'name: description' pair from 'layers with layer names as keys.'
WARNING -  griffe: vllm/v1/worker/utils.py:174: Confusing indentation for continuation line 8 in docstring, should be 4 * 2 = 8 spaces, not 6
WARNING -  griffe: vllm/v1/worker/utils.py:176: Confusing indentation for continuation line 10 in docstring, should be 4 * 2 = 8 spaces, not 6
WARNING -  griffe: vllm/v1/worker/utils.py:177: Confusing indentation for continuation line 11 in docstring, should be 4 * 2 = 8 spaces, not 6

WARNING -  griffe: vllm/v1/core/kv_cache_manager.py:61: No type or annotation for returned value 1
WARNING -  griffe: vllm/v1/core/kv_cache_manager.py:62: No type or annotation for returned value 2
WARNING -  griffe: vllm/v1/core/kv_cache_manager.py:63: No type or annotation for returned value 3

WARNING -  griffe: vllm/v1/worker/tpu_model_runner.py:567: Failed to get 'name: description' pair from 'to be scheduled for each request.'
WARNING -  griffe: vllm/v1/worker/tpu_model_runner.py:570: No type or annotation for returned value 1
WARNING -  griffe: vllm/v1/worker/tpu_model_runner.py:571: No type or annotation for returned value 'contains'

WARNING -  griffe: vllm/v1/core/encoder_cache_manager.py:258: Confusing indentation for continuation line 6 in docstring, should be 4 * 2 = 8 spaces, not 6
WARNING -  griffe: vllm/v1/core/encoder_cache_manager.py:260: Confusing indentation for continuation line 8 in docstring, should be 4 * 2 = 8 spaces, not 6
WARNING -  griffe: vllm/v1/core/encoder_cache_manager.py:306: Confusing indentation for continuation line 11 in docstring, should be 4 * 2 = 8 spaces, not 6
WARNING -  griffe: vllm/v1/core/encoder_cache_manager.py:308: Confusing indentation for continuation line 13 in docstring, should be 4 * 2 = 8 spaces, not 6

WARNING -  griffe: vllm/v1/attention/backends/cpu_attn.py:494: Failed to get 'name: description' pair from 'kv_cache = [2, num_blocks, block_size * num_kv_heads * head_size]'

WARNING -  griffe: vllm/v1/attention/backends/flex_attention.py:692: Failed to get 'name: description' pair from 'kv_cache = [2, num_blocks, block_size, num_kv_heads, head_size]'

WARNING -  griffe: vllm/v1/attention/backends/pallas.py:238: Failed to get 'name: description' pair from 'kv_cache = [num_blocks, block_size, num_kv_heads * 2, head_size]'
WARNING -  griffe: vllm/v1/attention/backends/pallas.py:332: Failed to get 'name: description' pair from 'kv_cache = [num_blocks, block_size, num_kv_heads * 2, head_size]'

WARNING -  griffe: vllm/v1/attention/backends/rocm_aiter_fa.py:432: Failed to get 'name: description' pair from 'kv_cache = [2, num_blocks, block_size, num_kv_heads, head_size]'

WARNING -  griffe: vllm/v1/attention/backends/tree_attn.py:365: Failed to get 'name: description' pair from 'kv_cache = [2, num_blocks, block_size, num_kv_heads, head_size]'

WARNING -  griffe: vllm/v1/attention/backends/triton_attn.py:288: Failed to get 'name: description' pair from 'kv_cache = [2, num_blocks, block_size, num_kv_heads, head_size]'

WARNING -  griffe: vllm/v1/attention/backends/xformers.py:333: Failed to get 'name: description' pair from 'kv_cache = [2, num_blocks, block_size, num_kv_heads, head_size]'

WARNING -  griffe: vllm/v1/core/kv_cache_coordinator.py:121: No type or annotation for parameter 'num_tokens'
WARNING -  griffe: vllm/v1/core/kv_cache_coordinator.py:121: Parameter 'num_tokens' does not appear in the function signature

WARNING -  griffe: vllm/v1/executor/ray_distributed_executor.py:72: No type or annotation for parameter 'scheduler_output'

WARNING -  griffe: vllm/v1/metrics/prometheus.py:44: No type or annotation for returned value 'Registry'

WARNING -  griffe: vllm/v1/sample/logits_processor/interface.py:83: Failed to get 'name: description' pair from 'batch_update is non-None iff there have been'
WARNING -  griffe: vllm/v1/sample/logits_processor/interface.py:84: Failed to get 'name: description' pair from 'changes to the batch makeup.'

WARNING -  griffe: vllm/v1/sample/rejection_sampler.py:70: Parameter 'bonus_token_ids_tensor' does not appear in the function signature

WARNING -  griffe: vllm/v1/sample/tpu/sampler.py:91: No type or annotation for parameter 'logits'
WARNING -  griffe: vllm/v1/sample/tpu/sampler.py:91: Parameter 'logits' does not appear in the function signature

WARNING -  griffe: vllm/v1/structured_output/backend_types.py:126: Confusing indentation for continuation line 5 in docstring, should be 4 * 2 = 8 spaces, not 6
WARNING -  griffe: vllm/v1/structured_output/backend_types.py:112: Confusing indentation for continuation line 5 in docstring, should be 4 * 2 = 8 spaces, not 6

WARNING -  griffe: vllm/v1/worker/gpu_input_batch.py:529: No type or annotation for parameter 'empty_req_indices'
WARNING -  griffe: vllm/v1/worker/gpu_input_batch.py:529: Parameter 'empty_req_indices' does not appear in the function signature

WARNING -  griffe: vllm/v1/worker/gpu_model_runner.py:2955: Failed to get 'name: description' pair from 'correct size but uninitialized shape.'

WARNING -  griffe: vllm/v1/worker/worker_base.py:39: Failed to get 'name: description' pair from 'responsibilities'

WARNING -  griffe: vllm/core/block/naive_block.py:210: Failed to get 'name: description' pair from 'in whole allocator.'
WARNING -  griffe: vllm/core/block/prefix_caching_block.py:64: Parameter 'block_ids(Optional[Iterable[int]],' does not appear in the function signature

Signed-off-by: Zerohertz <ohg3417@gmail.com>
WARNING -  griffe: vllm/core/scheduler.py:660: Failed to get 'name: description' pair from 'that are currently running'

Signed-off-by: Zerohertz <ohg3417@gmail.com>
WARNING -  griffe: vllm/v1/attention/backends/flash_attn.py:441: Failed to get 'name: description' pair from 'kv_cache = [2, num_blocks, block_size, num_kv_heads, head_size]'
WARNING -  griffe: vllm/v1/attention/backends/flashinfer.py:641: Parameter '#' does not appear in the function signature
WARNING -  griffe: vllm/v1/attention/backends/flashinfer.py:642: Parameter '#' does not appear in the function signature

Signed-off-by: Zerohertz <ohg3417@gmail.com>
WARNING -  griffe: vllm/v1/worker/utils.py:280: Failed to get 'name: description' pair from 'layers with layer names as keys.'
WARNING -  griffe: vllm/v1/worker/utils.py:174: Confusing indentation for continuation line 8 in docstring, should be 4 * 2 = 8 spaces, not 6
WARNING -  griffe: vllm/v1/worker/utils.py:176: Confusing indentation for continuation line 10 in docstring, should be 4 * 2 = 8 spaces, not 6
WARNING -  griffe: vllm/v1/worker/utils.py:177: Confusing indentation for continuation line 11 in docstring, should be 4 * 2 = 8 spaces, not 6

Signed-off-by: Zerohertz <ohg3417@gmail.com>
@mergify mergify bot added the v1 label Aug 27, 2025
Signed-off-by: Hyogeun Oh (오효근) <ohg3417@gmail.com>
WARNING -  griffe: vllm/v1/core/kv_cache_manager.py:61: No type or annotation for returned value 1
WARNING -  griffe: vllm/v1/core/kv_cache_manager.py:62: No type or annotation for returned value 2
WARNING -  griffe: vllm/v1/core/kv_cache_manager.py:63: No type or annotation for returned value 3

Signed-off-by: Zerohertz <ohg3417@gmail.com>
WARNING -  griffe: vllm/v1/worker/tpu_model_runner.py:567: Failed to get 'name: description' pair from 'to be scheduled for each request.'
WARNING -  griffe: vllm/v1/worker/tpu_model_runner.py:570: No type or annotation for returned value 1
WARNING -  griffe: vllm/v1/worker/tpu_model_runner.py:571: No type or annotation for returned value 'contains'

Signed-off-by: Zerohertz <ohg3417@gmail.com>
WARNING -  griffe: vllm/v1/core/encoder_cache_manager.py:258: Confusing indentation for continuation line 6 in docstring, should be 4 * 2 = 8 spaces, not 6
WARNING -  griffe: vllm/v1/core/encoder_cache_manager.py:260: Confusing indentation for continuation line 8 in docstring, should be 4 * 2 = 8 spaces, not 6
WARNING -  griffe: vllm/v1/core/encoder_cache_manager.py:306: Confusing indentation for continuation line 11 in docstring, should be 4 * 2 = 8 spaces, not 6
WARNING -  griffe: vllm/v1/core/encoder_cache_manager.py:308: Confusing indentation for continuation line 13 in docstring, should be 4 * 2 = 8 spaces, not 6

Signed-off-by: Zerohertz <ohg3417@gmail.com>
WARNING -  griffe: vllm/v1/attention/backends/cpu_attn.py:494: Failed to get 'name: description' pair from 'kv_cache = [2, num_blocks, block_size * num_kv_heads * head_size]'

Signed-off-by: Zerohertz <ohg3417@gmail.com>
WARNING -  griffe: vllm/v1/attention/backends/flex_attention.py:692: Failed to get 'name: description' pair from 'kv_cache = [2, num_blocks, block_size, num_kv_heads, head_size]'

Signed-off-by: Zerohertz <ohg3417@gmail.com>
WARNING -  griffe: vllm/v1/attention/backends/pallas.py:238: Failed to get 'name: description' pair from 'kv_cache = [num_blocks, block_size, num_kv_heads * 2, head_size]'
WARNING -  griffe: vllm/v1/attention/backends/pallas.py:332: Failed to get 'name: description' pair from 'kv_cache = [num_blocks, block_size, num_kv_heads * 2, head_size]'

Signed-off-by: Zerohertz <ohg3417@gmail.com>
@mergify mergify bot added the tpu Related to Google TPUs label Aug 27, 2025
WARNING -  griffe: vllm/v1/attention/backends/rocm_aiter_fa.py:432: Failed to get 'name: description' pair from 'kv_cache = [2, num_blocks, block_size, num_kv_heads, head_size]'

Signed-off-by: Zerohertz <ohg3417@gmail.com>
WARNING -  griffe: vllm/v1/attention/backends/tree_attn.py:365: Failed to get 'name: description' pair from 'kv_cache = [2, num_blocks, block_size, num_kv_heads, head_size]'

Signed-off-by: Zerohertz <ohg3417@gmail.com>
WARNING -  griffe: vllm/v1/attention/backends/triton_attn.py:288: Failed to get 'name: description' pair from 'kv_cache = [2, num_blocks, block_size, num_kv_heads, head_size]'

Signed-off-by: Zerohertz <ohg3417@gmail.com>
WARNING -  griffe: vllm/v1/attention/backends/xformers.py:333: Failed to get 'name: description' pair from 'kv_cache = [2, num_blocks, block_size, num_kv_heads, head_size]'

Signed-off-by: Zerohertz <ohg3417@gmail.com>
WARNING -  griffe: vllm/v1/core/kv_cache_coordinator.py:121: No type or annotation for parameter 'num_tokens'
WARNING -  griffe: vllm/v1/core/kv_cache_coordinator.py:121: Parameter 'num_tokens' does not appear in the function signature

Signed-off-by: Zerohertz <ohg3417@gmail.com>
WARNING -  griffe: vllm/v1/executor/ray_distributed_executor.py:72: No type or annotation for parameter 'scheduler_output'

Signed-off-by: Zerohertz <ohg3417@gmail.com>
WARNING -  griffe: vllm/v1/metrics/prometheus.py:44: No type or annotation for returned value 'Registry'

Signed-off-by: Zerohertz <ohg3417@gmail.com>
WARNING -  griffe: vllm/v1/sample/logits_processor/interface.py:83: Failed to get 'name: description' pair from 'batch_update is non-None iff there have been'
WARNING -  griffe: vllm/v1/sample/logits_processor/interface.py:84: Failed to get 'name: description' pair from 'changes to the batch makeup.'

Signed-off-by: Zerohertz <ohg3417@gmail.com>
WARNING -  griffe: vllm/v1/sample/rejection_sampler.py:70: Parameter 'bonus_token_ids_tensor' does not appear in the function signature

Signed-off-by: Zerohertz <ohg3417@gmail.com>
WARNING -  griffe: vllm/v1/sample/tpu/sampler.py:91: No type or annotation for parameter 'logits'
WARNING -  griffe: vllm/v1/sample/tpu/sampler.py:91: Parameter 'logits' does not appear in the function signature

Signed-off-by: Zerohertz <ohg3417@gmail.com>
WARNING -  griffe: vllm/v1/structured_output/backend_types.py:126: Confusing indentation for continuation line 5 in docstring, should be 4 * 2 = 8 spaces, not 6
WARNING -  griffe: vllm/v1/structured_output/backend_types.py:112: Confusing indentation for continuation line 5 in docstring, should be 4 * 2 = 8 spaces, not 6

Signed-off-by: Zerohertz <ohg3417@gmail.com>
WARNING -  griffe: vllm/v1/worker/gpu_input_batch.py:529: No type or annotation for parameter 'empty_req_indices'
WARNING -  griffe: vllm/v1/worker/gpu_input_batch.py:529: Parameter 'empty_req_indices' does not appear in the function signature

Signed-off-by: Zerohertz <ohg3417@gmail.com>
WARNING -  griffe: vllm/v1/worker/gpu_model_runner.py:2955: Failed to get 'name: description' pair from 'correct size but uninitialized shape.'

Signed-off-by: Zerohertz <ohg3417@gmail.com>
WARNING -  griffe: vllm/v1/worker/worker_base.py:39: Failed to get 'name: description' pair from 'responsibilities'

Signed-off-by: Zerohertz <ohg3417@gmail.com>
Signed-off-by: Zerohertz <ohg3417@gmail.com>
@Zerohertz Zerohertz requested a review from youkaichao as a code owner August 27, 2025 13:17
@Zerohertz Zerohertz changed the title (WIP) [Docs] Fix warnings in mkdocs build (continued) [Docs] Fix warnings in mkdocs build (continued) Aug 27, 2025
Signed-off-by: Zerohertz <ohg3417@gmail.com>
@Zerohertz
Copy link
Contributor Author

Zerohertz commented Aug 27, 2025

CI failed, but it is not related with this PR.

yapf................................................................................................Passed
ruff................................................................................................Passed
ruff-format.........................................................................................Passed
markdownlint........................................................................................Failed
- hook id: markdownlint
- exit code: 1
Error: docs/community/meetups.md:6:152 MD009/no-trailing-spaces Trailing spaces [Expected: 0 or 2; Actual: 1]
Lint GitHub Actions workflow files..................................................................Passed
pip-compile.........................................................................................Passed
reformat nightly_torch_test.txt to be in sync with test.in..........................................Passed

@hmellor
Copy link
Member

hmellor commented Aug 27, 2025

Just fixed that error on main, you if you merge from latest main it should be fixed

Copy link
Member

@hmellor hmellor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks for continuing this effort!

@hmellor hmellor enabled auto-merge (squash) August 27, 2025 13:46
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Aug 27, 2025
@hmellor hmellor merged commit 4e4d017 into vllm-project:main Aug 27, 2025
48 of 50 checks passed
epwalsh pushed a commit to epwalsh/vllm that referenced this pull request Aug 28, 2025
Signed-off-by: Zerohertz <ohg3417@gmail.com>
Signed-off-by: Hyogeun Oh (오효근) <ohg3417@gmail.com>
zhewenl pushed a commit to zhewenl/vllm that referenced this pull request Aug 28, 2025
Signed-off-by: Zerohertz <ohg3417@gmail.com>
Signed-off-by: Hyogeun Oh (오효근) <ohg3417@gmail.com>
@Zerohertz Zerohertz deleted the docs/mkdocs-warnings branch September 2, 2025 10:49
zhewenl pushed a commit to zhewenl/vllm that referenced this pull request Sep 3, 2025
Signed-off-by: Zerohertz <ohg3417@gmail.com>
Signed-off-by: Hyogeun Oh (오효근) <ohg3417@gmail.com>
FeiDaLI pushed a commit to FeiDaLI/vllm that referenced this pull request Sep 25, 2025
Signed-off-by: Zerohertz <ohg3417@gmail.com>
Signed-off-by: Hyogeun Oh (오효근) <ohg3417@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready ONLY add when PR is ready to merge/full CI is needed structured-output tpu Related to Google TPUs v1

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants