Skip to content

Remove old cutlass mla #23961

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 17, 2025
Merged

Remove old cutlass mla #23961

merged 4 commits into from
Sep 17, 2025
+10 −345

Conversation

@MatthewBonanni
Copy link
Contributor

@MatthewBonanni MatthewBonanni commented Aug 29, 2025 •
edited by github-actions bot
Loading

Purpose

Remove old CUTLASS MLA kernel, no longer used.

Test Plan

pytest tests/kernels/test_cutlass_mla_decode.py

Test Result

Test passes

Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
  • (Optional) Release notes update. If your change is user facing, please update the release notes draft in the Google Doc.

@MatthewBonanni MatthewBonanni marked this pull request as ready for review August 29, 2025 20:25
@MatthewBonanni MatthewBonanni marked this pull request as draft August 29, 2025 23:04
@MatthewBonanni MatthewBonanni marked this pull request as ready for review September 16, 2025 16:32
@mergify
Copy link

mergify bot commented Sep 16, 2025

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @MatthewBonanni.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify mergify bot added the needs-rebase label Sep 16, 2025
@MatthewBonanni
Remove old cutlass MLA kernel
6be6496 
Signed-off-by: Matthew Bonanni <mbonanni001@gmail.com>
@MatthewBonanni
Remove FORCE_OLD_CUTLASS_MLA option
fb84464 
Signed-off-by: Matthew Bonanni <mbonanni001@gmail.com>
@mergify mergify bot removed the needs-rebase label Sep 16, 2025
@MatthewBonanni
Address pre-commit
d091fd2 
Signed-off-by: Matthew Bonanni <mbonanni@redhat.com>
mgoin
mgoin approved these changes Sep 16, 2025
View reviewed changes
Copy link
Member

@mgoin mgoin left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if green, thanks!

@mgoin mgoin enabled auto-merge (squash) September 16, 2025 18:25
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Sep 16, 2025
yewentao256
yewentao256 approved these changes Sep 16, 2025
View reviewed changes
Copy link
Member

@yewentao256 yewentao256 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the work!

@mgoin mgoin merged commit 8f3616f into vllm-project:main Sep 17, 2025
80 checks passed
@MatthewBonanni MatthewBonanni deleted the remove_old_cutlass_mla branch September 17, 2025 14:32
FeiDaLI pushed a commit to FeiDaLI/vllm that referenced this pull request Sep 25, 2025
@MatthewBonanni @FeiDaLI
Remove old cutlass mla (vllm-project#23961)
3826a6b 
Signed-off-by: Matthew Bonanni <mbonanni001@gmail.com>
Signed-off-by: Matthew Bonanni <mbonanni@redhat.com>
charlifu pushed a commit to ROCm/vllm that referenced this pull request Sep 25, 2025
@MatthewBonanni @charlifu
Remove old cutlass mla (vllm-project#23961)
e86407a 
Signed-off-by: Matthew Bonanni <mbonanni001@gmail.com>
Signed-off-by: Matthew Bonanni <mbonanni@redhat.com>
Signed-off-by: charlifu <charlifu@amd.com>
xuebwang-amd pushed a commit to xuebwang-amd/vllm that referenced this pull request Oct 10, 2025
@MatthewBonanni @xuebwang-amd
Remove old cutlass mla (vllm-project#23961)
e1067e8 
Signed-off-by: Matthew Bonanni <mbonanni001@gmail.com>
Signed-off-by: Matthew Bonanni <mbonanni@redhat.com>
Signed-off-by: xuebwang-amd <xuebwang@amd.com>
choprahetarth pushed a commit to Tandemn-Labs/vllm that referenced this pull request Oct 11, 2025
@MatthewBonanni @choprahetarth
Remove old cutlass mla (vllm-project#23961)
158d8b5 
Signed-off-by: Matthew Bonanni <mbonanni001@gmail.com>
Signed-off-by: Matthew Bonanni <mbonanni@redhat.com>
xuebwang-amd pushed a commit to xuebwang-amd/vllm that referenced this pull request Oct 24, 2025
@MatthewBonanni @xuebwang-amd
Remove old cutlass mla (vllm-project#23961)
1922e36 
Signed-off-by: Matthew Bonanni <mbonanni001@gmail.com>
Signed-off-by: Matthew Bonanni <mbonanni@redhat.com>
Signed-off-by: xuebwang-amd <xuebwang@amd.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mgoin mgoin mgoin approved these changes

@yewentao256 yewentao256 yewentao256 approved these changes

@tlrmchlsmth tlrmchlsmth Awaiting requested review from tlrmchlsmth tlrmchlsmth is a code owner

@WoosukKwon WoosukKwon Awaiting requested review from WoosukKwon

@robertgshaw2-redhat robertgshaw2-redhat Awaiting requested review from robertgshaw2-redhat

@njhill njhill Awaiting requested review from njhill

@ywang96 ywang96 Awaiting requested review from ywang96

@comaniac comaniac Awaiting requested review from comaniac

@alexm-redhat alexm-redhat Awaiting requested review from alexm-redhat

@LucasWilkinson LucasWilkinson Awaiting requested review from LucasWilkinson LucasWilkinson is a code owner

Assignees

No one assigned

Labels

ci/build ready ONLY add when PR is ready to merge/full CI is needed v1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@MatthewBonanni @mgoin @yewentao256