Skip to content

Conversation

@hmellor
Copy link
Member

@hmellor hmellor commented Sep 1, 2025

Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
@mergify mergify bot added the ci/build label Sep 1, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the transformers library from version 4.55.2 to 4.55.3 across the requirement files. The change itself is straightforward. However, I've raised a concern about the version specifier in requirements/common.txt. Using >= can be risky for a project like vLLM that has deep integrations with transformers. I've suggested using a more restrictive pessimistic constraint (~=) to prevent potential breakages from future minor version updates.

@Isotr0py Isotr0py enabled auto-merge (squash) September 1, 2025 11:17
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Sep 1, 2025
@njhill
Copy link
Member

njhill commented Sep 3, 2025

We should make sure that #24159 is merged before / with this one.

@hmellor
Copy link
Member Author

hmellor commented Sep 3, 2025

Ok, happy to wait for that one

@DarkLight1337
Copy link
Member

The Hybrid models tests failure looks related

@DarkLight1337
Copy link
Member

cc @tdoublep @tlrmchlsmth

@DarkLight1337
Copy link
Member

Pipeline + Context Parallelism Test is also not failing on main so PTAL @hmellor

@hmellor
Copy link
Member Author

hmellor commented Sep 11, 2025

A new release has come out since I made this PR, I'll make a new one for 4.56.1

@hmellor hmellor closed this Sep 11, 2025
auto-merge was automatically disabled September 11, 2025 07:04

Pull request was closed

@hmellor
Copy link
Member Author

hmellor commented Sep 11, 2025

#24638

@hmellor hmellor deleted the transformers-4-55-3 branch September 29, 2025 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci/build ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants