-
-
Notifications
You must be signed in to change notification settings - Fork 10.7k
Update to Transformers 4.55.3 #24043
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the transformers library from version 4.55.2 to 4.55.3 across the requirement files. The change itself is straightforward. However, I've raised a concern about the version specifier in requirements/common.txt. Using >= can be risky for a project like vLLM that has deep integrations with transformers. I've suggested using a more restrictive pessimistic constraint (~=) to prevent potential breakages from future minor version updates.
|
We should make sure that #24159 is merged before / with this one. |
|
Ok, happy to wait for that one |
|
The Hybrid models tests failure looks related |
|
Pipeline + Context Parallelism Test is also not failing on main so PTAL @hmellor |
|
A new release has come out since I made this PR, I'll make a new one for 4.56.1 |
Pull request was closed
Merge after:
tokenizers == 0.22.0#24159