-
-
Couldn't load subscription status.
- Fork 10.8k
[BugFix] python collect_env.py and vllm collect-env compatibility with uv venv
#24066
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a fix for detecting uv virtual environments in collect_env.py, which is a good improvement for compatibility. The new is_uv_venv function correctly checks for both the UV environment variable and the uv entry in pyvenv.cfg. I've suggested a small improvement to make the file parsing more robust and efficient.
collect_env.py and vllm collect-env compatibility with uv venvcollect_env.py and vllm collect-env compatibility with uv venv
collect_env.py and vllm collect-env compatibility with uv venvpython collect_env.py and vllm collect-env compatibility with uv venv
7a4a366 to
f993c37
Compare
|
Hi @DarkLight1337 @yihong0618, Would it be possible to kindly ask you to review this PR? |
f993c37 to
53689ab
Compare
I think its good |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mgoin is OOO so I'll just stamp this
Signed-off-by: Kay Yan <kay.yan@daocloud.io>
Head branch was pushed to by a user without write access
53689ab to
46a4a2b
Compare
… with uv venv (vllm-project#24066) Signed-off-by: Kay Yan <kay.yan@daocloud.io>
… with uv venv (vllm-project#24066) Signed-off-by: Kay Yan <kay.yan@daocloud.io>
… with uv venv (vllm-project#24066) Signed-off-by: Kay Yan <kay.yan@daocloud.io> Signed-off-by: xuebwang-amd <xuebwang@amd.com>
… with uv venv (vllm-project#24066) Signed-off-by: Kay Yan <kay.yan@daocloud.io> Signed-off-by: xuebwang-amd <xuebwang@amd.com>
Purpose
Fix: #24063
This PR fixes issues when running
python collect_env.pyandvllm collect-envinside a uv venv environment. The changes ensure correct environment detection and reporting, resolving errors and inconsistencies specific to uv venv setups.Test Plan
Test Result
After change:
If no change, print error
Could not collect pip list output (pip or uv module not available), the same as #24063Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.