Skip to content

Conversation

@jeejeelee
Copy link
Collaborator

@jeejeelee jeejeelee commented Sep 2, 2025

Purpose

  • the main branch:
 [deep_gemm_moe.py:58] DeepGemm disabled due to unaligned problem size. M: 96, N: 768, K: 2048. M should >= align size and N and K must be multiples of 128.This is not an error and we will fall back to triton
  • this PR
 DeepGemm disabled due to unaligned problem size. M: 120, N: 768, K: 2048. M should >= 128 and N and K must be multiples of 128. This is not an error and we will fall back to triton.

Test Plan

Test Result


Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
  • (Optional) Release notes update. If your change is user facing, please update the release notes draft in the Google Doc.

Signed-off-by: Jee Jee Li <pandaleefree@gmail.com>
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request improves a debug log message in vllm/model_executor/layers/fused_moe/deep_gemm_moe.py to correctly display the required alignment value. The change is correct and enhances the clarity of the log message for debugging purposes. Given that the change is minor and there are no high or critical severity issues, I have no specific review comments.

Copy link
Member

@yewentao256 yewentao256 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find, thanks for the work!

@yewentao256 yewentao256 added the ready ONLY add when PR is ready to merge/full CI is needed label Sep 4, 2025
@yewentao256 yewentao256 enabled auto-merge (squash) September 4, 2025 14:21
@yewentao256 yewentao256 merged commit 94866d7 into vllm-project:main Sep 4, 2025
48 of 50 checks passed
@jeejeelee jeejeelee deleted the improve-deepgemm-print branch September 4, 2025 16:23
eicherseiji pushed a commit to eicherseiji/vllm that referenced this pull request Sep 9, 2025
Signed-off-by: Jee Jee Li <pandaleefree@gmail.com>
skyloevil pushed a commit to skyloevil/vllm that referenced this pull request Sep 13, 2025
Signed-off-by: Jee Jee Li <pandaleefree@gmail.com>
FeiDaLI pushed a commit to FeiDaLI/vllm that referenced this pull request Sep 25, 2025
Signed-off-by: Jee Jee Li <pandaleefree@gmail.com>
xuebwang-amd pushed a commit to xuebwang-amd/vllm that referenced this pull request Oct 10, 2025
Signed-off-by: Jee Jee Li <pandaleefree@gmail.com>
Signed-off-by: xuebwang-amd <xuebwang@amd.com>
xuebwang-amd pushed a commit to xuebwang-amd/vllm that referenced this pull request Oct 24, 2025
Signed-off-by: Jee Jee Li <pandaleefree@gmail.com>
Signed-off-by: xuebwang-amd <xuebwang@amd.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants