-
-
Notifications
You must be signed in to change notification settings - Fork 11.3k
update spec decode metrics to use throughput #24127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update spec decode metrics to use throughput #24127
Conversation
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run You ask your reviewers to trigger select CI tests on top of Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add If you have any questions, please reach out to us on Slack at https://slack.vllm.ai. 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the speculative decoding metrics to include throughput for drafted and accepted tokens. The changes correctly use time.monotonic() to measure the elapsed time for accurate throughput calculation. The implementation is sound, adding last_log_time to SpecDecodingLogging, calculating throughput in the log method, and updating the log message accordingly. The code handles potential division-by-zero errors. Overall, the changes are a good addition for better performance monitoring, and I have no high or critical severity feedback.
75cef51 to
710a8fa
Compare
Jialin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thanks for patching the change to OSS. Please add some screen shot in the test plan.
Signed-off-by: Andrew Xia <axia@meta.com>
Signed-off-by: Andrew Xia <axia@meta.com>
710a8fa to
e2fbcce
Compare
Signed-off-by: Andrew Xia <axia@meta.com>
luccafong
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
benchislett
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…ughput (vllm-project#24127) Signed-off-by: Andrew Xia <axia@meta.com>
…ughput (vllm-project#24127) Signed-off-by: Andrew Xia <axia@meta.com>
…ughput (vllm-project#24127) Signed-off-by: Andrew Xia <axia@meta.com>
…ughput (vllm-project#24127) Signed-off-by: Andrew Xia <axia@meta.com> Signed-off-by: xuebwang-amd <xuebwang@amd.com>
…ughput (vllm-project#24127) Signed-off-by: Andrew Xia <axia@meta.com> Signed-off-by: xuebwang-amd <xuebwang@amd.com>
Purpose
In encountering vllm speculative decoding code, we noticed that throughput was a more useful metric to read than the total number of tokens. Worked with @Jialin to devise better metrics
Test Plan
send a curl request to a vllm server running spec decoding
server
Test Result
metrics
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.