-
-
Notifications
You must be signed in to change notification settings - Fork 11.1k
Lora bias(enable_lora_bias) deprecate warning #24339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lora bias(enable_lora_bias) deprecate warning #24339
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds a deprecation warning for the enable_lora_bias option in LoRAConfig. The changes correctly update the docstrings and CLI help text to reflect this deprecation. However, the implementation of the warning in LoRAConfig.__post_init__ includes a redundant logging call alongside warnings.warn, which could lead to duplicate messages for the user. My review includes a suggestion to remove this redundancy for better consistency and user experience.
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run You ask your reviewers to trigger select CI tests on top of Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add If you have any questions, please reach out to us on Slack at https://slack.vllm.ai. 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the work!
|
Curious, @jeejeelee do PR raisers don't have merge request? Or is it available only after the |
|
PR submitters typically don't have direct merge permissions and need to go through code review before being merged by authorized members |
Signed-off-by: Jee Jee Li <pandaleefree@gmail.com> Co-authored-by: Jee Jee Li <pandaleefree@gmail.com>
Signed-off-by: Jee Jee Li <pandaleefree@gmail.com> Co-authored-by: Jee Jee Li <pandaleefree@gmail.com>
Signed-off-by: Jee Jee Li <pandaleefree@gmail.com> Co-authored-by: Jee Jee Li <pandaleefree@gmail.com>
Signed-off-by: Jee Jee Li <pandaleefree@gmail.com> Co-authored-by: Jee Jee Li <pandaleefree@gmail.com> Signed-off-by: xuebwang-amd <xuebwang@amd.com>
Signed-off-by: Jee Jee Li <pandaleefree@gmail.com> Co-authored-by: Jee Jee Li <pandaleefree@gmail.com> Signed-off-by: xuebwang-amd <xuebwang@amd.com>
Purpose
Add a deprecation warning logger to eventually remove LoRA bias and cleanup the code as well.
Relates to Step 1 of #23892 to add a warning log.
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.