Skip to content

[VLM] Migrate remain DP-supported ViT models to use disable_tp #24363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 11, 2025
Merged

[VLM] Migrate remain DP-supported ViT models to use disable_tp #24363

merged 4 commits into from
Sep 11, 2025

Conversation

Isotr0py
Copy link
Member

@Isotr0py Isotr0py commented Sep 6, 2025 •
edited by github-actions bot
Loading

Purpose

Test Plan

Models to test:

  • Llama4
  • Idefics3
  • Qwen2.5-VL (missed VisionPatchMerger update in previous PR)

Test Result

All models can still work with mm_encoder_tp_mode="data"

Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
  • (Optional) Release notes update. If your change is user facing, please update the release notes draft in the Google Doc.

@Isotr0py
migrate remain ViT to use disable_tp
7a680db 
Signed-off-by: Isotr0py <mozf@mail2.sysu.edu.cn>
@mergify mergify bot added llama Related to Llama models qwen Related to Qwen models labels Sep 6, 2025
@david6666666
Copy link
Contributor

nice one

@mergify Mergify
Copy link

mergify bot commented Sep 10, 2025

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @Isotr0py.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify mergify bot added the needs-rebase label Sep 10, 2025
@Isotr0py
Merge branch 'main' into disable-vit-tp
084b1d3 
Signed-off-by: Isotr0py <mozf@mail2.sysu.edu.cn>
@mergify mergify bot removed the needs-rebase label Sep 11, 2025
@Isotr0py Isotr0py marked this pull request as ready for review September 11, 2025 16:22
@Isotr0py
Copy link
Member Author

Have confirmed all models can still work locally.

@DarkLight1337 DarkLight1337 added the ready ONLY add when PR is ready to merge/full CI is needed label Sep 11, 2025
@DarkLight1337 DarkLight1337 enabled auto-merge (squash) September 11, 2025 16:27
@DarkLight1337 DarkLight1337 merged commit bb2b512 into vllm-project:main Sep 11, 2025
42 checks passed
@Isotr0py Isotr0py deleted the disable-vit-tp branch September 12, 2025 02:24
skyloevil pushed a commit to skyloevil/vllm that referenced this pull request Sep 13, 2025
@Isotr0py @skyloevil
[VLM] Migrate remain DP-supported ViT models to use disable_tp (vll…
287b75b 
…m-project#24363)

Signed-off-by: Isotr0py <mozf@mail2.sysu.edu.cn>
dsxsteven pushed a commit to dsxsteven/vllm_splitPR that referenced this pull request Sep 15, 2025
@Isotr0py @dsxsteven
[VLM] Migrate remain DP-supported ViT models to use disable_tp (vll…
5b3d94d 
…m-project#24363)

Signed-off-by: Isotr0py <mozf@mail2.sysu.edu.cn>
FeiDaLI pushed a commit to FeiDaLI/vllm that referenced this pull request Sep 25, 2025
@Isotr0py @FeiDaLI
[VLM] Migrate remain DP-supported ViT models to use disable_tp (vll…
d632045 
…m-project#24363)

Signed-off-by: Isotr0py <mozf@mail2.sysu.edu.cn>
xuebwang-amd pushed a commit to xuebwang-amd/vllm that referenced this pull request Oct 10, 2025
@Isotr0py @xuebwang-amd
[VLM] Migrate remain DP-supported ViT models to use disable_tp (vll…
fa8b907 
…m-project#24363)

Signed-off-by: Isotr0py <mozf@mail2.sysu.edu.cn>
Signed-off-by: xuebwang-amd <xuebwang@amd.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DarkLight1337 DarkLight1337 DarkLight1337 approved these changes

@sighingnow sighingnow Awaiting requested review from sighingnow sighingnow is a code owner

Assignees

No one assigned

Labels

llama Related to Llama models qwen Related to Qwen models ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Isotr0py @david6666666 @DarkLight1337