[Bugfix] Fix broken deepseek fp8 TP weights loading #24367
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
tp_size
andtp_rank
throughself.update_param_tp_status()
(I just realized that
__post_init__
is never called fornn.Module
because it's not a dataclass. My bad. 😅)Also cc @minosfuture, can you check if this PR also fixed the issue on your side? Thanks!
Test Plan
Test Result
Verified on dummy tiny Deepseek-v3 FP8 checkpoint with 1 MLA layer.
Essential Elements of an Effective PR Description Checklist
supported_models.md
andexamples
for a new model.