Skip to content

[CI][Fix] deterministic seed for flaky CI runs on structured outputs #24380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 7, 2025
Merged

[CI][Fix] deterministic seed for flaky CI runs on structured outputs #24380

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions tests/v1/entrypoints/llm/test_struct_output_generate.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,9 +41,8 @@
PARAMS_MODELS_BACKENDS_TOKENIZER_MODE = [
("mistralai/Ministral-8B-Instruct-2410", "xgrammar", "auto", None),
("mistralai/Ministral-8B-Instruct-2410", "guidance", "auto", None),
#FIXME: This test is flaky on CI thus disabled
#("mistralai/Ministral-8B-Instruct-2410", "lm-format-enforcer", "auto",
# None),
("mistralai/Ministral-8B-Instruct-2410", "lm-format-enforcer", "auto",
None),
("mistralai/Ministral-8B-Instruct-2410", "xgrammar", "mistral", None),
("Qwen/Qwen2.5-1.5B-Instruct", "xgrammar", "auto", None),
("Qwen/Qwen2.5-1.5B-Instruct", "lm-format-enforcer", "auto", None),
Expand Down Expand Up @@ -123,6 +122,7 @@ def test_structured_output(
guided_decoding_backend=guided_decoding_backend,
guided_decoding_disable_any_whitespace=(guided_decoding_backend
in {"xgrammar", "guidance"}),
seed=120,
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Sep 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

While adding a seed here helps make this test deterministic, the fix for CI flakiness seems incomplete. Other tests in this file also use non-deterministic sampling parameters but are not seeded, which could lead to continued flakiness.

Specifically, the LLM initializations in the following tests should also have a deterministic seed (e.g., seed=120):

  • test_structured_output_with_reasoning_matrices
  • test_structured_output_auto_mode
  • test_structured_output_batched_with_non_guided_requests

Applying this change consistently will help ensure CI stability.

tokenizer_mode=tokenizer_mode,
speculative_config=speculative_config)

Expand Down