Skip to content

Conversation

@jeejeelee
Copy link
Collaborator

@jeejeelee jeejeelee commented Sep 8, 2025

Purpose

Test Plan

python examplexamples/offline_inference/vision_language.py \                                                                                                             
    --modality image \
    --model-type qwen2_5_omni
  • The model utilizes Qwen/Qwen2.5-Omni-3B, with additional parameters: quantization="bitsandbytes" and enable_lora=True

Test Result

I can generated the reasonable result on my local device:

--------------------------------------------------
Well, this image shows a tall tower, which looks like the Tokyo Skytree. There are also lots of pink cherry blossom branches in the foreground. The sky is blue and clear. It's a really nice scene. What do you think about it?
--------------------------------------------------
Well, this image shows the Tokyo Skytree. It's a tall tower with a lot of intricate details on its top. And there are cherry blossom trees in the foreground, with lots of pink flowers. The sky is clear and blue. It's a really nice picture. So, what do you think about it?
--------------------------------------------------
Well, this image shows a tall tower with a lot of pink flowers around it. The flowers are in full bloom, and the tower is kind of in the background. It looks like a beautiful scene, maybe a place in Japan. What do you think about it?
--------------------------------------------------
Well, this image shows a tall tower in the background. It's surrounded by cherry blossom trees. The flowers are in full bloom, with lots of pink blossoms. The sky is clear and blue. It looks like a beautiful spring scene. What do you think about it?

Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
  • (Optional) Release notes update. If your change is user facing, please update the release notes draft in the Google Doc.

Signed-off-by: Jee Jee Li <pandaleefree@gmail.com>
@mergify mergify bot added the qwen Related to Qwen models label Sep 8, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request re-enables LoRA support for the qwen2_5_omni_thinker model, which is a prerequisite for bitsandbytes (BNB) quantization. The changes correctly add the SupportsLoRA interface, define the packed_modules_mapping for merged layers in both the language and vision components, and implement the get_mm_mapping method to identify the different parts of the multimodal model. These changes appear correct and necessary to fix the LoRA functionality that was removed in a previous refactoring. The implementation aligns well with vLLM's patterns for multimodal LoRA support. I have reviewed the code and found no issues.

@Isotr0py Isotr0py enabled auto-merge (squash) September 8, 2025 07:34
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Sep 8, 2025
@vllm-bot vllm-bot merged commit 6f4a82f into vllm-project:main Sep 8, 2025
48 of 50 checks passed
@jeejeelee jeejeelee deleted the qwen25omni-bnb-lora branch September 8, 2025 16:45
eicherseiji pushed a commit to eicherseiji/vllm that referenced this pull request Sep 9, 2025
Signed-off-by: Jee Jee Li <pandaleefree@gmail.com>
skyloevil pushed a commit to skyloevil/vllm that referenced this pull request Sep 13, 2025
Signed-off-by: Jee Jee Li <pandaleefree@gmail.com>
FeiDaLI pushed a commit to FeiDaLI/vllm that referenced this pull request Sep 25, 2025
Signed-off-by: Jee Jee Li <pandaleefree@gmail.com>
xuebwang-amd pushed a commit to xuebwang-amd/vllm that referenced this pull request Oct 10, 2025
Signed-off-by: Jee Jee Li <pandaleefree@gmail.com>
Signed-off-by: xuebwang-amd <xuebwang@amd.com>
xuebwang-amd pushed a commit to xuebwang-amd/vllm that referenced this pull request Oct 24, 2025
Signed-off-by: Jee Jee Li <pandaleefree@gmail.com>
Signed-off-by: xuebwang-amd <xuebwang@amd.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

qwen Related to Qwen models ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature]: qwen2.5 omni doesn't support bnb quantification.

3 participants