[Bugfix] Fix Apertus HF repo name #24447
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
DarkLight1337
added
ready
Isotr0py
approved these changes
Sep 8, 2025
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request correctly updates the Hugging Face repository name for the Apertus model in the test suite and model registry. It also adds the model to the supported models documentation. I have one suggestion to improve the consistency of the documentation.
hmellor
approved these changes
Sep 8, 2025
|
Emu3 test is failing now: https://buildkite.com/vllm/ci/builds/29803/steps/canvas?jid=01992aa7-239e-4392-9ae0-d5ed04ea3c2d |
|
I see, let me look into this (seems it's broken at core code about configuration)... 😅 |
5 tasks
huggingface/transformers#40766 should fix this. |
eicherseiji
pushed a commit
to eicherseiji/vllm
that referenced
this pull request
Sep 9, 2025
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
skyloevil
pushed a commit
to skyloevil/vllm
that referenced
this pull request
Sep 13, 2025
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
FeiDaLI
pushed a commit
to FeiDaLI/vllm
that referenced
this pull request
Sep 25, 2025
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
xuebwang-amd
pushed a commit
to xuebwang-amd/vllm
that referenced
this pull request
Oct 10, 2025
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk> Signed-off-by: xuebwang-amd <xuebwang@amd.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
The HF repo got renamed since the initial release #23068. Also add this model to Supported Models page.
Fix Transformers Nightly Models Test https://buildkite.com/vllm/ci/builds/29705/steps/canvas?sid=01992255-a7b7-4ec3-bfde-a3cc263a7e3c
Test Plan
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.