Skip to content

Conversation

@lacora
Copy link
Contributor

@lacora lacora commented Sep 8, 2025

Followup on the test failure

Purpose

Support system prompt customization via injections
remove developer messages if all tools enabled are builtin tools
support container tool
support context with session id on MCP
support MCP session clean up for container

Test Plan

Tested on oss gpt with evals, sample requests
Jupyter python tool for AIME25 is slightly lower than model card

Test Result

Verfied AIME results

zhiweiz and others added 4 commits September 4, 2025 10:05
Signed-off-by: zhiweiz <zhiweiz@fb.com>
Signed-off-by: Aaron Pham <contact@aarnphm.xyz>
Signed-off-by: Lu Fang <30275821+houseroad@users.noreply.github.com>
@github-actions
Copy link

github-actions bot commented Sep 8, 2025

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors.

You ask your reviewers to trigger select CI tests on top of fastcheck CI.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

If you have any questions, please reach out to us on Slack at https://slack.vllm.ai.

🚀

@mergify
Copy link

mergify bot commented Sep 8, 2025

⚠️ The sha of the head commit of this PR conflicts with #23386. Mergify cannot evaluate rules on this PR. ⚠️

@lacora lacora changed the title First [gpt-oss] Harmony changes with container tool support Sep 8, 2025
@lacora lacora marked this pull request as ready for review September 8, 2025 21:29
@lacora lacora requested a review from aarnphm as a code owner September 8, 2025 21:29
@mergify mergify bot added frontend gpt-oss Related to GPT-OSS models labels Sep 9, 2025
@yeqcharlotte
Copy link
Collaborator

no longer needed given #23386 is merged?

@lacora lacora closed this Sep 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

frontend gpt-oss Related to GPT-OSS models

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants