-
-
Notifications
You must be signed in to change notification settings - Fork 11.3k
[Model] Add Olmo3 model implementation #24534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
f46685f
Copy Olmo2 model as Olmo3
2015aroras 5f1e407
Add Olmo3Config
2015aroras becfaaf
Add Olmo3 model implementation
2015aroras 097ef6a
Add Olmo3 to test registry and supported models
2015aroras ce477b1
Minor comment updates
2015aroras 61b1b26
Support Olmo3 architecture in Olmo2 implementation
2015aroras 3d6e099
Merge branch 'main' into shanea/olmo3-official
Isotr0py 9542485
Fix registry for Olmo3 model
2015aroras 743406c
Merge branch 'main' into shanea/olmo3-official
2015aroras File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,80 @@ | ||
| # SPDX-License-Identifier: Apache-2.0 | ||
| # SPDX-FileCopyrightText: Copyright contributors to the vLLM project | ||
|
|
||
| from transformers.configuration_utils import PretrainedConfig | ||
|
|
||
|
|
||
| class Olmo3Config(PretrainedConfig): | ||
|
|
||
| model_type = "olmo3" | ||
| keys_to_ignore_at_inference = ["past_key_values"] | ||
|
|
||
| def __init__( | ||
| self, | ||
| vocab_size=50304, | ||
| hidden_size=4096, | ||
| intermediate_size=11008, | ||
| num_hidden_layers=32, | ||
| num_attention_heads=32, | ||
| num_key_value_heads=None, | ||
| hidden_act="silu", | ||
| max_position_embeddings=2048, | ||
| initializer_range=0.02, | ||
| use_cache=True, | ||
| pad_token_id=1, | ||
| bos_token_id=None, | ||
| eos_token_id=50279, | ||
| tie_word_embeddings=False, | ||
| rope_theta=10000.0, | ||
| rope_scaling=None, | ||
| attention_bias=False, | ||
| attention_dropout=0.0, | ||
| rms_norm_eps=1e-5, | ||
| sliding_window=4096, | ||
| layer_types=None, | ||
| **kwargs, | ||
| ): | ||
| # This model uses Olmo3ForCausalLM in transformers but Olmo2ForCausalLM | ||
| # in vLLM. | ||
| if "architectures" not in kwargs: | ||
| kwargs["architectures"] = ["Olmo2ForCausalLM"] | ||
| elif "Olmo3ForCausalLM" in kwargs["architectures"]: | ||
| kwargs["architectures"].remove("Olmo3ForCausalLM") | ||
| kwargs["architectures"].append("Olmo2ForCausalLM") | ||
|
|
||
| super().__init__( | ||
| pad_token_id=pad_token_id, | ||
| bos_token_id=bos_token_id, | ||
| eos_token_id=eos_token_id, | ||
| tie_word_embeddings=tie_word_embeddings, | ||
| **kwargs, | ||
| ) | ||
| self.vocab_size = vocab_size | ||
| self.max_position_embeddings = max_position_embeddings | ||
| self.hidden_size = hidden_size | ||
| self.intermediate_size = intermediate_size | ||
| self.num_hidden_layers = num_hidden_layers | ||
| self.num_attention_heads = num_attention_heads | ||
|
|
||
| # for backward compatibility | ||
| if num_key_value_heads is None: | ||
| num_key_value_heads = num_attention_heads | ||
|
|
||
| self.num_key_value_heads = num_key_value_heads | ||
| self.hidden_act = hidden_act | ||
| self.initializer_range = initializer_range | ||
| self.use_cache = use_cache | ||
| self.rope_theta = rope_theta | ||
| self.rope_scaling = rope_scaling | ||
| self.attention_bias = attention_bias | ||
| self.attention_dropout = attention_dropout | ||
|
|
||
| self.rms_norm_eps = rms_norm_eps | ||
|
|
||
| self.sliding_window = sliding_window | ||
| self.layer_types = layer_types | ||
| if self.layer_types is None: | ||
| self.layer_types = [ | ||
| "sliding_attention" if (i + 1) % 4 != 0 else "full_attention" | ||
| for i in range(self.num_hidden_layers) | ||
| ] |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to add
is_available_online=False(if the repo isn't available yet) and/ormin_transformers_version(if the model isn't supported by the current version)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
9542485 The problem was that I put
olmo3instead ofolmo2in the registry, which I have fixed in this commit. The above two solutions don't apply since the repo is public and this implementation is intended to work even before the transformers implementation is released.